about summary refs log tree commit diff
path: root/math
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2015-06-25 21:46:02 +0000
committerJoseph Myers <joseph@codesourcery.com>2015-06-25 21:46:02 +0000
commita8e2112ae3e57fae592d84af2936a61d6239a248 (patch)
treec9a07fad850af11667fffc681b0c5d96c9fe7e3a /math
parent037e4b993fe03d33055f92dddf7242abd9f6d1de (diff)
downloadglibc-a8e2112ae3e57fae592d84af2936a61d6239a248.tar.gz
glibc-a8e2112ae3e57fae592d84af2936a61d6239a248.tar.xz
glibc-a8e2112ae3e57fae592d84af2936a61d6239a248.zip
Use round-to-nearest internally in jn, test with ALL_RM_TEST (bug 18602).
Some existing jn tests, if run in non-default rounding modes, produce
errors above those accepted in glibc, which causes problems for moving
tests of jn to use ALL_RM_TEST.  This patch makes jn set rounding
to-nearest internally, as was done for yn some time ago, then computes
the appropriate underflowing value for results that underflowed to
zero in to-nearest, and moves the tests to ALL_RM_TEST.  It does
nothing about the general inaccuracy of Bessel function
implementations in glibc, though it should make jn more accurate on
average in non-default rounding modes through reduced error
accumulation.  The recomputation of results that underflowed to zero
should as a side-effect fix some cases of bug 16559, where jn just
used an exact zero, but that is *not* the goal of this patch and other
cases of that bug remain unfixed.

(Most of the changes in the patch are reindentation to add new scopes
for SET_RESTORE_ROUND*.)

Tested for x86_64, x86, powerpc and mips64.

	[BZ #16559]
	[BZ #18602]
	* sysdeps/ieee754/dbl-64/e_jn.c (__ieee754_jn): Set
	round-to-nearest internally then recompute results that
	underflowed to zero in the original rounding mode.
	* sysdeps/ieee754/flt-32/e_jnf.c (__ieee754_jnf): Likewise.
	* sysdeps/ieee754/ldbl-128/e_jnl.c (__ieee754_jnl): Likewise.
	* sysdeps/ieee754/ldbl-128ibm/e_jnl.c (__ieee754_jnl): Likewise.
	* sysdeps/ieee754/ldbl-96/e_jnl.c (__ieee754_jnl): Likewise
	* math/libm-test.inc (jn_test): Use ALL_RM_TEST.
	* sysdeps/i386/fpu/libm-test-ulps: Update.
	* sysdeps/x86_64/fpu/libm-test-ulps: Likewise.
Diffstat (limited to 'math')
-rw-r--r--math/libm-test.inc4
1 files changed, 1 insertions, 3 deletions
diff --git a/math/libm-test.inc b/math/libm-test.inc
index da8f8caec4..9e402ab634 100644
--- a/math/libm-test.inc
+++ b/math/libm-test.inc
@@ -7486,9 +7486,7 @@ static const struct test_if_f_data jn_test_data[] =
 static void
 jn_test (void)
 {
-  START (jn,, 0);
-  RUN_TEST_LOOP_if_f (jn, jn_test_data, );
-  END;
+  ALL_RM_TEST (jn, 0, jn_test_data, RUN_TEST_LOOP_if_f, END);
 }