diff options
author | Joseph Myers <joseph@codesourcery.com> | 2017-09-12 20:00:00 +0000 |
---|---|---|
committer | Joseph Myers <joseph@codesourcery.com> | 2017-09-12 20:00:00 +0000 |
commit | a891caff7a911227627eb147e9bfcb7737b2bc2b (patch) | |
tree | 59e4551acb6161a85421f7f6014dc897e01c01d5 /math | |
parent | a1a78204162561872634d517b82e8a865c7058cc (diff) | |
download | glibc-a891caff7a911227627eb147e9bfcb7737b2bc2b.tar.gz glibc-a891caff7a911227627eb147e9bfcb7737b2bc2b.tar.xz glibc-a891caff7a911227627eb147e9bfcb7737b2bc2b.zip |
Remove declare_mgen_alias_2.
The libm template machinery includes a macro declare_mgen_alias_2, to define two function aliases rather than one. This macro is only used in one place, to define ldexp and scalbn, and only has one nondefault definition, for double in the case where long double has the same format. That definition is because declare_mgen_alias for double, in that case, defines <internal-func>l as an alias of <internal-func>, so cannot be called twice for aliases of the same function. Now, I suspect the <internal-func>l aliases are generally not needed (with maybe a few exceptions such as __clog10l, which is an exported function). But even in the presence of them, there is no need for a special declare_mgen_alias_2 macro for this case. This patch eliminates the need for such a macro by defining __wrap_scalbn<suffix> as an alias of __ldexp<suffix>, and then using that when defining the scalbn public aliases. This is similar to how such internal aliases are created for functions with multiple symbol versions, for example. Tested for x86_64, and with build-many-glibcs.py. (There *are* some cases where installed stripped shared libraries change - not in the generated code but because such changes to static symbols on input to ld, even nonexported symbols that don't affect the code or dynamic symbols, can affect the particular representation in the output of string tables, hash tables etc.) * sysdeps/generic/math-type-macros.h [!declare_mgen_alias_2] (declare_mgen_alias_2): Remove. * sysdeps/generic/math-type-macros-double.h [NO_LONG_DOUBLE && !declare_mgen_alias_2] (declare_mgen_alias_2): Likewise. * math/s_ldexp_template.c (M_SUF (__wrap_scalbn)): Define strong alias. (ldexp): Define with declare_mgen_alias. (scalbn): Likewise.
Diffstat (limited to 'math')
-rw-r--r-- | math/s_ldexp_template.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/math/s_ldexp_template.c b/math/s_ldexp_template.c index 42a83334c3..3aa56f9f89 100644 --- a/math/s_ldexp_template.c +++ b/math/s_ldexp_template.c @@ -27,6 +27,8 @@ M_SUF (__ldexp) (FLOAT value, int exp) return value; } -declare_mgen_alias_2 (__ldexp, ldexp, scalbn); +declare_mgen_alias (__ldexp, ldexp) +strong_alias (M_SUF (__ldexp), M_SUF (__wrap_scalbn)) +declare_mgen_alias (__wrap_scalbn, scalbn) /* Note, versioning issues are punted to ldbl-opt in this case. */ |