diff options
author | Gabriel F. T. Gomes <gabriel@inconstante.eti.br> | 2017-11-03 10:44:36 -0200 |
---|---|---|
committer | Gabriel F. T. Gomes <gabriel@inconstante.eti.br> | 2017-12-19 23:26:59 -0200 |
commit | c85e54ac6cef0faed7b7ffc722f52523dec59bf5 (patch) | |
tree | 594a7a95e759e7035ee80ea0dee46b09f917f9aa /math/test-math-iseqsig.cc | |
parent | 10e93d968716ab82931d593bada121c17c0a4b93 (diff) | |
download | glibc-c85e54ac6cef0faed7b7ffc722f52523dec59bf5.tar.gz glibc-c85e54ac6cef0faed7b7ffc722f52523dec59bf5.tar.xz glibc-c85e54ac6cef0faed7b7ffc722f52523dec59bf5.zip |
Provide a C++ version of iseqsig (bug 22377)
In C++ mode, __MATH_TG cannot be used for defining iseqsig, because __MATH_TG relies on __builtin_types_compatible_p, which is a C-only builtin. This is true when float128 is provided as an ABI-distinct type from long double. Moreover, the comparison macros from ISO C take two floating-point arguments, which need not have the same type. Choosing what underlying function to call requires evaluating the formats of the arguments, then selecting which is wider. The macro __MATH_EVAL_FMT2 provides this information, however, only the type of the macro expansion is relevant (actually evaluating the expression would be incorrect). This patch provides a C++ version of iseqsig, in which only the type of __MATH_EVAL_FMT2 (__typeof or decltype) is used as a template parameter for __iseqsig_type. This function calls the appropriate underlying function. Tested for powerpc64le and x86_64. [BZ #22377] * math/Makefile [C++] (tests): Add test for iseqsig. * math/math.h [C++] (iseqsig): New implementation, which does not rely on __MATH_TG/__builtin_types_compatible_p. * math/test-math-iseqsig.cc: New file. * sysdeps/powerpc/powerpc64le/Makefile (CFLAGS-test-math-iseqsig.cc): New variable.
Diffstat (limited to 'math/test-math-iseqsig.cc')
-rw-r--r-- | math/test-math-iseqsig.cc | 111 |
1 files changed, 111 insertions, 0 deletions
diff --git a/math/test-math-iseqsig.cc b/math/test-math-iseqsig.cc new file mode 100644 index 0000000000..48e8f1e799 --- /dev/null +++ b/math/test-math-iseqsig.cc @@ -0,0 +1,111 @@ +/* Test for the C++ implementation of iseqsig. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <http://www.gnu.org/licenses/>. */ + +#define _GNU_SOURCE 1 +#include <math.h> +#include <stdio.h> + +#include <limits> + +/* There is no NaN for _Float128 in std::numeric_limits. + Include ieee754_float128.h and use the bitfields in the union + ieee854_float128.ieee_nan to build a NaN. */ +#if __HAVE_DISTINCT_FLOAT128 +# include <ieee754_float128.h> +#endif + +#include <support/check.h> + +static void +check (int actual, int expected, const char *actual_expr, int line) +{ + if (actual != expected) + { + support_record_failure (); + printf ("%s:%d: error: %s\n", __FILE__, line, actual_expr); + printf ("%s:%d: expected: %d\n", __FILE__, line, expected); + printf ("%s:%d: actual: %d\n", __FILE__, line, actual); + } +} + +#define CHECK(actual, expected) \ + check ((actual), (expected), #actual, __LINE__) + +template <class T1, class T2> +static void +check_type () +{ + T1 t1 = 0; + T2 t2 = 0; + CHECK (iseqsig (t1, t2), 1); + + t2 = 1; + CHECK (iseqsig (t1, t2), 0); + + if (std::numeric_limits<T1>::has_quiet_NaN + && std::numeric_limits<T2>::has_quiet_NaN) + { + CHECK (iseqsig (std::numeric_limits<T1>::quiet_NaN (), t2), 0); + CHECK (iseqsig (t1, std::numeric_limits<T2>::quiet_NaN ()), 0); + CHECK (iseqsig (std::numeric_limits<T1>::quiet_NaN (), + std::numeric_limits<T2>::quiet_NaN ()), 0); + } +} + +#if __HAVE_DISTINCT_FLOAT128 +static void +check_float128 () +{ + ieee854_float128 q1, q2, q3_nan; + + q1.d = 0; + q2.d = 1; + q3_nan.ieee_nan.negative = 0; + q3_nan.ieee_nan.exponent = 0x7FFF; + q3_nan.ieee_nan.quiet_nan = 1; + q3_nan.ieee_nan.mantissa0 = 0x0000; + q3_nan.ieee_nan.mantissa1 = 0x00000000; + q3_nan.ieee_nan.mantissa2 = 0x00000000; + q3_nan.ieee_nan.mantissa3 = 0x00000000; + + CHECK (iseqsig (q1.d, q1.d), 1); + CHECK (iseqsig (q1.d, q2.d), 0); + CHECK (iseqsig (q1.d, q3_nan.d), 0); + CHECK (iseqsig (q3_nan.d, q3_nan.d), 0); +} +#endif + +static int +do_test (void) +{ + check_type<float, float> (); + check_type<float, double> (); + check_type<float, long double> (); + check_type<double, float> (); + check_type<double, double> (); + check_type<double, long double> (); + check_type<long double, float> (); + check_type<long double, double> (); + check_type<long double, long double> (); +#if __HAVE_DISTINCT_FLOAT128 + check_float128 (); +#endif + return 0; +} + +#include <support/test-driver.c> |