diff options
author | Niklas Hambüchen <mail@nh2.me> | 2019-08-08 22:02:27 +0200 |
---|---|---|
committer | Arjun Shankar <ashankar@redhat.com> | 2019-11-19 12:23:07 +0100 |
commit | 5f620768fbdae75f71af78852be228ad5577623d (patch) | |
tree | d9d9bf2d099723e114fea6ad444b23be4d44f219 /malloc | |
parent | c347431fb5fd3f124c05e82fb7a661b396e86f82 (diff) | |
download | glibc-5f620768fbdae75f71af78852be228ad5577623d.tar.gz glibc-5f620768fbdae75f71af78852be228ad5577623d.tar.xz glibc-5f620768fbdae75f71af78852be228ad5577623d.zip |
malloc: Fix missing accounting of top chunk in malloc_info [BZ #24026]
Fixes `<total type="rest" size="..."> incorrectly showing as 0 most of the time. The rest value being wrong is significant because to compute the actual amount of memory handed out via malloc, the user must subtract it from <system type="current" size="...">. That result being wrong makes investigating memory fragmentation issues like <https://bugzilla.redhat.com/show_bug.cgi?id=843478> close to impossible. (cherry picked from commit b6d2c4475d5abc05dd009575b90556bdd3c78ad0)
Diffstat (limited to 'malloc')
-rw-r--r-- | malloc/malloc.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/malloc/malloc.c b/malloc/malloc.c index 343d89f489..0e65d636cd 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -5406,6 +5406,12 @@ __malloc_info (int options, FILE *fp) __libc_lock_lock (ar_ptr->mutex); + /* Account for top chunk. The top-most available chunk is + treated specially and is never in any bin. See "initial_top" + comments. */ + avail = chunksize (ar_ptr->top); + nblocks = 1; /* Top always exists. */ + for (size_t i = 0; i < NFASTBINS; ++i) { mchunkptr p = fastbin (ar_ptr, i); |