about summary refs log tree commit diff
path: root/login/pututline_r.c
diff options
context:
space:
mode:
authorRoland McGrath <roland@gnu.org>1996-07-18 08:43:26 +0000
committerRoland McGrath <roland@gnu.org>1996-07-18 08:43:26 +0000
commit49b986270035c7f86c3dc85383fd1da2e413fef9 (patch)
tree5b1236203c804457e180793a67e3e0e4b489a3d8 /login/pututline_r.c
parentd7bca0d30b5d3c8ae8421a1994ba24b1b56370d7 (diff)
downloadglibc-49b986270035c7f86c3dc85383fd1da2e413fef9.tar.gz
glibc-49b986270035c7f86c3dc85383fd1da2e413fef9.tar.xz
glibc-49b986270035c7f86c3dc85383fd1da2e413fef9.zip
Thu Jul 18 04:33:21 1996 Roland McGrath <roland@baalperazim.frob.com> cvs/libc-960718
	* sysdeps/mach/hurd/errnos.awk: Move EWOULDBLOCK check before errno==0
	check.  mib's clueless hacking broke it.

Thu Jul 18 04:27:21 1996  Roland McGrath  <roland@delasyd.gnu.ai.mit.edu>

	* Makerules ($(libdir)/libc.so): Add missing / after $(cryptobjdir).

Wed Jul 17 10:54:20 1996  David Mosberger-Tang  <davidm@azstarnet.com>

	* sysdeps/unix/sysv/linux/alpha/start.S: Move to ...
	* sysdeps/alpha/elf/start.S: here.

	* misc/sys/ustat.h: New file.
	* misc/ustat.h: Ditto.
	* sysdeps/generic/ustatbits.h: Ditto.
	* libc-orig/sysdeps/stub/ustat.c: Ditto.
	* sysdeps/unix/sysv/linux/ustatbits.h: Ditto.
	* misc/Makefile (headers): Mention ustat.h, sys/ustat.h, and
 	ustatbits.h.
	(routines): Mention ustat.

	* sysdeps/unix/sysv/linux/syscalls.list: Mention klogctl in
 	alphabetically correct place.  Mention ustat.

	* sysdeps/unix/alpha/sysdep.S: Make errno a bss symbol, not a
	common symbol (makes errno accessible from gdb).

	* login/pututline_r.c (pututline_r): Test ut_id in repositioning
	test, not ut_type.

	* login/logwtmp.c (logwtmp): Reimplemented.  Must ensure that a
 	record always gets appended at end of file (wtmp is a log file,
 	after all).  Set ut_type to DEAD_PROCESS if name is empty.

	* login/getutid_r.c (getutid_r): Handle search for UT_TYPE in
	separate loop from search for UT_ID.  Fix code so it is in
	sync with Unix man page.

	* login/getutline_r.c (getutline_r): Stop searching only if
 	ut_line matches and type is either USER_PROCESS or LOGIN_PROCESS.

Tue Jul 16 15:06:18 1996  David Mosberger-Tang  <davidm@azstarnet.com>

	* sysdeps/unix/sysv/linux/netinet/in.h: Base on <linux/in.h> to
 	avoid duplicate declarations.

Sun Jul 14 19:08:55 1996  David Mosberger-Tang  <davidm@azstarnet.com>

	* manual/maint.texi (Supported Configurations): Add alpha-gnu-linux
	and alpha-gnu-linuxecoff targets.

Fri Jul 12 16:58:44 1996  David Mosberger-Tang  <davidm@azstarnet.com>

	* sysdeps/unix/sysv/linux/netinet/in.h: Declare bindresvport().

Sat Jun 22 23:30:07 1996  David Mosberger-Tang  <davidm@azstarnet.com>

	* resolv/res_send.c (res_send): Declare FROMLEN as size_t instead
	of int.

	* resolv/res_comp.c (res_hnok): Use empty statement in place
	of NULL (which generates a "useless expression" warning in
	gcc).
Diffstat (limited to 'login/pututline_r.c')
-rw-r--r--login/pututline_r.c17
1 files changed, 10 insertions, 7 deletions
diff --git a/login/pututline_r.c b/login/pututline_r.c
index 4c9a91fdec..42994e899f 100644
--- a/login/pututline_r.c
+++ b/login/pututline_r.c
@@ -58,12 +58,15 @@ pututline_r (const struct utmp *id, struct utmp_data *utmp_data)
 	return -1;
     }
 
-#if _HAVE_UT_TYPE - 0
-  /* Seek position to write.  */
-  if (utmp_data->loc_utmp >= sizeof (struct utmp)
-      && utmp_data->ubuf.ut_type != id->ut_type)
+#if _HAVE_UT_ID - 0
+  /* Check whether we need to reposition.  Repositioning is necessary
+     either if the data in UTMP_DATA is not valid or if the ids don't
+     match: */
+  if (utmp_data->loc_utmp < (off_t) sizeof (struct utmp)
+      || strncmp(utmp_data->ubuf.ut_id, id->ut_id, sizeof (id->ut_id)) != 0)
     {
-      /* We must not overwrite the data in UTMP_DATA.  */
+      /* We must not overwrite the data in UTMP_DATA since ID may be
+	 aliasing it.  */
       struct utmp_data *data_tmp = alloca (sizeof (*data_tmp));
       struct utmp *dummy;
 
@@ -77,7 +80,7 @@ pututline_r (const struct utmp *id, struct utmp_data *utmp_data)
 	       pointer now is at the end of the file.  */
 	    return -1;
 
-	  /* Set position pointer to position after adding of the record.  */
+	  /* Set position pointer to position behind the record.  */
 	  utmp_data->loc_utmp += sizeof (struct utmp);
 	}
     }
@@ -98,7 +101,7 @@ pututline_r (const struct utmp *id, struct utmp_data *utmp_data)
 
   if (result >= 0)
     /* Position file correctly.  */
-    if (utmp_data->loc_utmp < sizeof (struct utmp))
+    if (utmp_data->loc_utmp < (off_t) sizeof (struct utmp))
       /* Not located at any valid entry.  Add at the end.  */
       {
 	result = lseek (utmp_data->ut_fd, 0L, SEEK_END);