about summary refs log tree commit diff
path: root/localedata
diff options
context:
space:
mode:
authorSiddhesh Poyarekar <siddhesh@sourceware.org>2021-10-20 18:12:41 +0530
committerSiddhesh Poyarekar <siddhesh@sourceware.org>2021-10-20 18:12:41 +0530
commita643f60c53876be0d57b4b7373770e6cb356fd13 (patch)
treed11ac8a63cd4f7820eb635e1ade8809b2a5aa913 /localedata
parente938c02748402c50f60ba0eb983273e7b52937d1 (diff)
downloadglibc-a643f60c53876be0d57b4b7373770e6cb356fd13.tar.gz
glibc-a643f60c53876be0d57b4b7373770e6cb356fd13.tar.xz
glibc-a643f60c53876be0d57b4b7373770e6cb356fd13.zip
Make sure that the fortified function conditionals are constant
In _FORTIFY_SOURCE=3, the size expression may be non-constant,
resulting in branches in the inline functions remaining intact and
causing a tiny overhead.  Clang (and in future, gcc) make sure that
the -1 case is always safe, i.e. any comparison of the generated
expression with (size_t)-1 is always false so that bit is taken care
of.  The rest is avoidable since we want the _chk variant whenever we
have a size expression and it's not -1.

Rework the conditionals in a uniform way to clearly indicate two
conditions at compile time:

- Either the size is unknown (-1) or we know at compile time that the
  operation length is less than the object size.  We can call the
  original function in this case.  It could be that either the length,
  object size or both are non-constant, but the compiler, through
  range analysis, is able to fold the *comparison* to a constant.

- The size and length are known and the compiler can see at compile
  time that operation length > object size.  This is valid grounds for
  a warning at compile time, followed by emitting the _chk variant.

For everything else, emit the _chk variant.

This simplifies most of the fortified function implementations and at
the same time, ensures that only one call from _chk or the regular
function is emitted.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Diffstat (limited to 'localedata')
0 files changed, 0 insertions, 0 deletions