about summary refs log tree commit diff
path: root/io/Makefile
diff options
context:
space:
mode:
authorAurelien Jarno <aurelien@aurel32.net>2023-08-28 23:30:37 +0200
committerAurelien Jarno <aurelien@aurel32.net>2023-09-16 10:59:23 +0200
commit762a747faefad05cbfa463a1e7f7b00684d56f77 (patch)
tree5ea2462bd280266a402e138a73f55f78e5d55987 /io/Makefile
parente3ccb230a961b4797510e6a1f5f21fd9021853e7 (diff)
downloadglibc-762a747faefad05cbfa463a1e7f7b00684d56f77.tar.gz
glibc-762a747faefad05cbfa463a1e7f7b00684d56f77.tar.xz
glibc-762a747faefad05cbfa463a1e7f7b00684d56f77.zip
io: Fix record locking contants for powerpc64 with __USE_FILE_OFFSET64
Commit 5f828ff824e3b7cd1 ("io: Fix F_GETLK, F_SETLK, and F_SETLKW for
powerpc64") fixed an issue with the value of the lock constants on
powerpc64 when not using __USE_FILE_OFFSET64, but it ended-up also
changing the value when using __USE_FILE_OFFSET64 causing an API change.

Fix that by also checking that define, restoring the pre
4d0fe291aed3a476a commit values:

Default values:
- F_GETLK: 5
- F_SETLK: 6
- F_SETLKW: 7

With -D_FILE_OFFSET_BITS=64:
- F_GETLK: 12
- F_SETLK: 13
- F_SETLKW: 14

At the same time, it has been noticed that there was no test for io lock
with __USE_FILE_OFFSET64, so just add one.

Tested on x86_64-linux-gnu, i686-linux-gnu and
powerpc64le-unknown-linux-gnu.

Resolves: BZ #30804.
Co-authored-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
(cherry picked from commit 434bf72a94de68f0cc7fbf3c44bf38c1911b70cb)
Diffstat (limited to 'io/Makefile')
-rw-r--r--io/Makefile4
1 files changed, 3 insertions, 1 deletions
diff --git a/io/Makefile b/io/Makefile
index fb363c612c..b896484320 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -59,6 +59,7 @@ routines :=								\
 	ftw64-time64							\
 	closefrom close_range
 
+
 others		:= pwd
 test-srcs	:= ftwtest ftwtest-time64
 tests		:= test-utime test-stat test-stat2 test-lfs tst-getcwd \
@@ -81,7 +82,8 @@ tests		:= test-utime test-stat test-stat2 test-lfs tst-getcwd \
 		   tst-closefrom \
 		   tst-close_range \
 		   tst-ftw-bz28126 \
-		   tst-fcntl-lock
+		   tst-fcntl-lock \
+		   tst-fcntl-lock-lfs
 
 tests-time64 := \
   tst-fcntl-time64 \