diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2017-10-01 15:07:06 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2017-10-01 15:07:23 -0700 |
| commit | 8bcdb7e0c5346d2e9d61b208d80fd8213e1dbd90 (patch) | |
| tree | 487999b729d1c71503ec9215a26d95644ca5efed /intl | |
| parent | 8ed3b64330cd24e2a17d8794a871cab034707a33 (diff) | |
| download | glibc-8bcdb7e0c5346d2e9d61b208d80fd8213e1dbd90.tar.gz glibc-8bcdb7e0c5346d2e9d61b208d80fd8213e1dbd90.tar.xz glibc-8bcdb7e0c5346d2e9d61b208d80fd8213e1dbd90.zip | |
Mark internal functions with attribute_hidden [BZ #18822]
Mark internal functions with attribute_hidden to allow direct access to
internal functions within libc.so and libc.a without using GOT nor PLT.
Size comparison of libc.so:
On x86-64:
text data bss dec hex
Before: 1728577 20584 17088 1766249 1af369
After : 1728593 20584 17088 1766265 1af379
The only change is __gconv_release_shlib in iconv/gconv_dl.c is inlined
since it is hidden, which increases the code size of gconv_dl.os by 18
bytes.
On i686:
text data bss dec hex
Before: 1869039 11444 11112 1891595 1cdd0b
After : 1868635 11444 11112 1891191 1cdb77
The code size is decreased by avoiding GOT/PLT for hidden functions.
[BZ #18822]
* iconv/gconv_int.h (__gconv_open): Add attribute_hidden.
(__gconv_close): Likewise.
(__gconv): Likewise.
(__gconv_find_transform): Likewise.
(__gconv_lookup_cache): Likewise.
(__gconv_compare_alias_cache): Likewise.
(__gconv_load_cache): Likewise.
(__gconv_get_path): Likewise.
(__gconv_close_transform): Likewise.
(__gconv_release_cache): Likewise.
(__gconv_find_shlib): Likewise.
(__gconv_release_shlib): Likewise.
(__gconv_get_builtin_trans): Likewise.
(__gconv_compare_alias): Likewise.
* include/dlfcn.h (_dlerror_run): Likewise.
* include/stdio.h (__fortify_fail_abort): Likewise.
* include/time.h (__tz_compute): Likewise.
(__strptime_internal): Likewise.
* intl/gettextP.h (_nl_find_domain): Likewise.
(_nl_load_domain): Likewise.
(_nl_find_msg): Likewise.
* intl/plural-exp.h (FREE_EXPRESSION): Likewise.
(EXTRACT_PLURAL_EXPRESSION): Likewise.
* locale/coll-lookup.h (__collidx_table_lookup): Likewise.
* resolv/gai_misc.h (__gai_enqueue_request): Likewise.
(__gai_find_request): Likewise.
(__gai_remove_request): Likewise.
(__gai_notify): Likewise.
(__gai_notify_only): Likewise.
* sysdeps/generic/aio_misc.h (__aio_sigqueue): Likewise.
* sysdeps/generic/ldsodefs.h (_dl_fini): Likewise.
(_dl_non_dynamic_init): Likewise.
(_dl_aux_init): Likewise.
* sysdeps/i386/machine-gmon.h (mcount_internal): Likewise.
* sysdeps/unix/sysv/linux/i386/olddirent.h (__old_getdents64):
Likewise.
* wcsmbs/wcsmbsload.h (__wcsmbs_load_conv): Likewise.
(__wcsmbs_clone_conv): Likewise.
(__wcsmbs_named_conv): Likewise.
Diffstat (limited to 'intl')
| -rw-r--r-- | intl/gettextP.h | 12 | ||||
| -rw-r--r-- | intl/plural-exp.h | 5 |
2 files changed, 11 insertions, 6 deletions
diff --git a/intl/gettextP.h b/intl/gettextP.h index 8fcfb5bef8..75b203ab52 100644 --- a/intl/gettextP.h +++ b/intl/gettextP.h @@ -251,19 +251,23 @@ extern const char *_nl_locale_name_default (void); struct loaded_l10nfile *_nl_find_domain (const char *__dirname, char *__locale, const char *__domainname, - struct binding *__domainbinding); + struct binding *__domainbinding) + attribute_hidden; void _nl_load_domain (struct loaded_l10nfile *__domain, - struct binding *__domainbinding); + struct binding *__domainbinding) + attribute_hidden; #ifdef IN_LIBGLOCALE char *_nl_find_msg (struct loaded_l10nfile *domain_file, struct binding *domainbinding, const char *encoding, const char *msgid, - size_t *lengthp); + size_t *lengthp) + attribute_hidden; #else char *_nl_find_msg (struct loaded_l10nfile *domain_file, struct binding *domainbinding, const char *msgid, - int convert, size_t *lengthp); + int convert, size_t *lengthp) + attribute_hidden; #endif /* The internal variables in the standalone libintl.a must have different diff --git a/intl/plural-exp.h b/intl/plural-exp.h index 4833fcdf35..a4ffff9f91 100644 --- a/intl/plural-exp.h +++ b/intl/plural-exp.h @@ -101,12 +101,13 @@ struct parse_args # define EXTRACT_PLURAL_EXPRESSION extract_plural_expression #endif -extern void FREE_EXPRESSION (struct expression *exp); +extern void FREE_EXPRESSION (struct expression *exp) attribute_hidden; extern int PLURAL_PARSE (struct parse_args *arg); extern const struct expression GERMANIC_PLURAL attribute_hidden; extern void EXTRACT_PLURAL_EXPRESSION (const char *nullentry, const struct expression **pluralp, - unsigned long int *npluralsp); + unsigned long int *npluralsp) + attribute_hidden; #if !defined (_LIBC) && !defined (IN_LIBINTL) && !defined (IN_LIBGLOCALE) extern unsigned long int plural_eval (const struct expression *pexp, |