diff options
| author | H.J. Lu <hongjiu.lu@intel.com> | 2016-02-18 11:00:33 -0200 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2016-02-18 14:55:29 -0200 |
| commit | 16396c41deab45f715ffd813280d9d685b3b281e (patch) | |
| tree | 5ed0830f0b3524559d6a099c3a19af14223ef28a /include/string.h | |
| parent | 6400ae6ecf6376af230d3ec82a8541848d3239e9 (diff) | |
| download | glibc-16396c41deab45f715ffd813280d9d685b3b281e.tar.gz glibc-16396c41deab45f715ffd813280d9d685b3b281e.tar.xz glibc-16396c41deab45f715ffd813280d9d685b3b281e.zip | |
Add _STRING_INLINE_unaligned and string_private.h
As discussed in https://sourceware.org/ml/libc-alpha/2015-10/msg00403.html the setting of _STRING_ARCH_unaligned currently controls the external GLIBC ABI as well as selecting the use of unaligned accesses withing GLIBC. Since _STRING_ARCH_unaligned was recently changed for AArch64, this would potentially break the ABI in GLIBC 2.23, so split the uses and add _STRING_INLINE_unaligned to select the string ABI. This setting must be fixed for each target, while _STRING_ARCH_unaligned may be changed from release to release. _STRING_ARCH_unaligned is used unconditionally in glibc. But <bits/string.h>, which defines _STRING_ARCH_unaligned, isn't included with -Os. Since _STRING_ARCH_unaligned is internal to glibc and may change between glibc releases, it should be made private to glibc. _STRING_ARCH_unaligned should defined in the new string_private.h heade file which is included unconditionally from internal <string.h> for glibc build. [BZ #19462] * bits/string.h (_STRING_ARCH_unaligned): Renamed to ... (_STRING_INLINE_unaligned): This. * include/string.h: Include <string_private.h>. * string/bits/string2.h: Replace _STRING_ARCH_unaligned with _STRING_INLINE_unaligned. * sysdeps/aarch64/bits/string.h (_STRING_ARCH_unaligned): Removed. (_STRING_INLINE_unaligned): New. * sysdeps/aarch64/string_private.h: New file. * sysdeps/generic/string_private.h: Likewise. * sysdeps/m68k/m680x0/m68020/string_private.h: Likewise. * sysdeps/s390/string_private.h: Likewise. * sysdeps/x86/string_private.h: Likewise. * sysdeps/m68k/m680x0/m68020/bits/string.h (_STRING_ARCH_unaligned): Renamed to ... (_STRING_INLINE_unaligned): This. * sysdeps/s390/bits/string.h (_STRING_ARCH_unaligned): Renamed to ... (_STRING_INLINE_unaligned): This. * sysdeps/sparc/bits/string.h (_STRING_ARCH_unaligned): Renamed to ... (_STRING_INLINE_unaligned): This. * sysdeps/x86/bits/string.h (_STRING_ARCH_unaligned): Renamed to ... (_STRING_INLINE_unaligned): This.
Diffstat (limited to 'include/string.h')
| -rw-r--r-- | include/string.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/string.h b/include/string.h index a684fd9624..e145bfdb4c 100644 --- a/include/string.h +++ b/include/string.h @@ -46,6 +46,9 @@ extern int __ffs (int __i) __attribute__ ((const)); extern char *__strerror_r (int __errnum, char *__buf, size_t __buflen); #endif +/* Get _STRING_ARCH_unaligned. */ +#include <string_private.h> + /* Now the real definitions. We do this here since some of the functions above are defined as macros in the headers. */ #include <string/string.h> |