about summary refs log tree commit diff
path: root/include/programs
diff options
context:
space:
mode:
authorMartin Sebor <msebor@redhat.com>2021-05-16 15:21:18 -0600
committerMartin Sebor <msebor@redhat.com>2021-05-16 15:21:18 -0600
commitc1760eaf3b575ad174fd88b252fd16bd525fa818 (patch)
treeed5620ec7d1bdbf9cdc4ca9a791069388a62c268 /include/programs
parent390c43ba1f586066caace103c7701c80e6088cbd (diff)
downloadglibc-c1760eaf3b575ad174fd88b252fd16bd525fa818.tar.gz
glibc-c1760eaf3b575ad174fd88b252fd16bd525fa818.tar.xz
glibc-c1760eaf3b575ad174fd88b252fd16bd525fa818.zip
Enable support for GCC 11 -Wmismatched-dealloc.
To help detect common kinds of memory (and other resource) management
bugs, GCC 11 adds support for the detection of mismatched calls to
allocation and deallocation functions.  At each call site to a known
deallocation function GCC checks the set of allocation functions
the former can be paired with and, if the two don't match, issues
a -Wmismatched-dealloc warning (something similar happens in C++
for mismatched calls to new and delete).  GCC also uses the same
mechanism to detect attempts to deallocate objects not allocated
by any allocation function (or pointers past the first byte into
allocated objects) by -Wfree-nonheap-object.

This support is enabled for built-in functions like malloc and free.
To extend it beyond those, GCC extends attribute malloc to designate
a deallocation function to which pointers returned from the allocation
function may be passed to deallocate the allocated objects.  Another,
optional argument designates the positional argument to which
the pointer must be passed.

This change is the first step in enabling this extended support for
Glibc.
Diffstat (limited to 'include/programs')
-rw-r--r--include/programs/xmalloc.h8
1 files changed, 4 insertions, 4 deletions
diff --git a/include/programs/xmalloc.h b/include/programs/xmalloc.h
index 76e345f4ee..33871e22ef 100644
--- a/include/programs/xmalloc.h
+++ b/include/programs/xmalloc.h
@@ -23,11 +23,11 @@
 
 /* Prototypes for a few program-wide used functions.  */
 extern void *xmalloc (size_t n)
-  __attribute_malloc__ __attribute_alloc_size__ ((1));
+  __attribute_malloc__ __attribute_alloc_size__ ((1)) __attr_dealloc_free;
 extern void *xcalloc (size_t n, size_t s)
-  __attribute_malloc__ __attribute_alloc_size__ ((1, 2));
+  __attribute_malloc__ __attribute_alloc_size__ ((1, 2)) __attr_dealloc_free;
 extern void *xrealloc (void *o, size_t n)
-  __attribute_malloc__ __attribute_alloc_size__ ((2));
-extern char *xstrdup (const char *) __attribute_malloc__;
+  __attribute_malloc__ __attribute_alloc_size__ ((2)) __attr_dealloc_free;
+extern char *xstrdup (const char *) __attribute_malloc__ __attr_dealloc_free;
 
 #endif /* xmalloc.h */