about summary refs log tree commit diff
path: root/include/libc-symbols.h
diff options
context:
space:
mode:
authorSamuel Thibault <samuel.thibault@ens-lyon.org>2020-11-10 23:35:19 +0000
committerSamuel Thibault <samuel.thibault@ens-lyon.org>2020-11-11 02:36:22 +0100
commit3d3316b1dee885153d44210b2e95dba68d00613a (patch)
tree997c7734e51a76d2c11d0bfb5227f463c75df2e2 /include/libc-symbols.h
parenta40b18b2330026cedc07348481bf3219f668adca (diff)
downloadglibc-3d3316b1dee885153d44210b2e95dba68d00613a.tar.gz
glibc-3d3316b1dee885153d44210b2e95dba68d00613a.tar.xz
glibc-3d3316b1dee885153d44210b2e95dba68d00613a.zip
hurd: keep only required PLTs in ld.so
We need NO_RTLD_HIDDEN because of the need for PLT calls in ld.so.
See Roland's comment in
https://sourceware.org/bugzilla/show_bug.cgi?id=15605
"in the Hurd it's crucial that calls like __mmap be the libc ones
instead of the rtld-local ones after the bootstrap phase, when the
dynamic linker is being used for dlopen and the like."

We used to just avoid all hidden use in the rtld ; this commit switches to
keeping only those that should use PLT calls, i.e. essentially those defined in
sysdeps/mach/hurd/dl-sysdep.c:

__assert_fail
__assert_perror_fail
__*stat64
_exit

This fixes a few startup issues, notably the call to __tunable_get_val that is
made before PLTs are set up.
Diffstat (limited to 'include/libc-symbols.h')
-rw-r--r--include/libc-symbols.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index 60153bb50d..b8103b98bb 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -643,7 +643,7 @@ for linking")
 # define libc_hidden_data_ver(local, name)
 #endif
 
-#if IS_IN (rtld) && !defined NO_RTLD_HIDDEN
+#if IS_IN (rtld)
 # define rtld_hidden_proto(name, attrs...) hidden_proto (name, ##attrs)
 # define rtld_hidden_tls_proto(name, attrs...) hidden_tls_proto (name, ##attrs)
 # define rtld_hidden_def(name) hidden_def (name)