about summary refs log tree commit diff
path: root/include/libc-internal.h
diff options
context:
space:
mode:
authorNoah Goldstein <goldstein.w.n@gmail.com>2024-08-13 23:29:14 +0800
committerH.J. Lu <hjl.tools@gmail.com>2024-08-15 10:00:11 -0700
commitc0af0c2ba016030c778bc22c55f5f9498f96b8b9 (patch)
tree90d7fcb92c1f53a2257b9139b04067ed48bc4a68 /include/libc-internal.h
parent898f25e0b1026be5701d05715600be646e9d0714 (diff)
downloadglibc-c0af0c2ba016030c778bc22c55f5f9498f96b8b9.tar.gz
glibc-c0af0c2ba016030c778bc22c55f5f9498f96b8b9.tar.xz
glibc-c0af0c2ba016030c778bc22c55f5f9498f96b8b9.zip
x86: Fix bug in strchrnul-evex512 [BZ #32078]
Issue was we were expecting not matches with CHAR before the start of
the string in the page cross case.

The check code in the page cross case:
```
    and    $0xffffffffffffffc0,%rax
    vmovdqa64 (%rax),%zmm17
    vpcmpneqb %zmm17,%zmm16,%k1
    vptestmb %zmm17,%zmm17,%k0{%k1}
    kmovq  %k0,%rax
    inc    %rax
    shr    %cl,%rax
    je     L(continue)
```

expects that all characters that neither match null nor CHAR will be
1s in `rax` prior to the `inc`. Then the `inc` will overflow all of
the 1s where no relevant match was found.

This is incorrect in the page-cross case, as the
`vmovdqa64 (%rax),%zmm17` loads from before the start of the input
string.

If there are matches with CHAR before the start of the string, `rax`
won't properly overflow.

The fix is quite simple. Just replace:

```
    inc    %rax
    shr    %cl,%rax
```
With:
```
    sar    %cl,%rax
    inc    %rax
```

The arithmetic shift will clear any matches prior to the start of the
string while maintaining the signbit so the 1s can properly overflow
to zero in the case of no matches.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

(cherry picked from commit 7da08862471dfec6fdae731c2a5f351ad485c71f)
Diffstat (limited to 'include/libc-internal.h')
0 files changed, 0 insertions, 0 deletions