summary refs log tree commit diff
path: root/iconv/iconvconfig.c
diff options
context:
space:
mode:
authorGabriel F. T. Gomes <gabriel@inconstante.eti.br>2019-03-21 17:24:30 -0300
committerGabriel F. T. Gomes <gabriel@inconstante.eti.br>2019-03-21 17:53:03 -0300
commit5abcddd7949270998c6e8d99fdbbba821b664f8b (patch)
tree27501fa7879f5e6fef7b71ca7664e1fccb325d6f /iconv/iconvconfig.c
parentac64195ccd4f320659fd0058bc7524c6fd0b37b4 (diff)
downloadglibc-5abcddd7949270998c6e8d99fdbbba821b664f8b.tar.gz
glibc-5abcddd7949270998c6e8d99fdbbba821b664f8b.tar.xz
glibc-5abcddd7949270998c6e8d99fdbbba821b664f8b.zip
Fix parentheses error in iconvconfig.c and ld-collate.c [BZ #24372]
When -Werror=parentheses is in use, iconvconfig.c builds fail with:

  iconvconfig.c: In function ‘write_output’:
  iconvconfig.c:1084:34: error: suggest parentheses around ‘+’ inside ‘>>’ [-Werror=parentheses]
     hash_size = next_prime (nnames + nnames >> 1);
                             ~~~~~~~^~~~~~~~

This patch adds parentheses to the expression.  Not where suggested by
the compiler warning, but where it produces the expected result, i.e.:
where it has the effect of multiplying nnames by 1.5.

Likewise for elem_size in ld-collate.c.

Tested for powerpc64le.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'iconv/iconvconfig.c')
-rw-r--r--iconv/iconvconfig.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/iconv/iconvconfig.c b/iconv/iconvconfig.c
index 1e6066cdf0..f75e46dc16 100644
--- a/iconv/iconvconfig.c
+++ b/iconv/iconvconfig.c
@@ -1081,7 +1081,7 @@ write_output (void)
      Creating a perfect hash table is not reasonable here.  Therefore
      we use open hashing and a table size which is the next prime 50%
      larger than the number of strings.  */
-  hash_size = next_prime (nnames + nnames >> 1);
+  hash_size = next_prime (nnames + (nnames >> 1));
   hash_table = (struct hash_entry *) xcalloc (hash_size,
 					      sizeof (struct hash_entry));
   /* Fill the hash table.  */