about summary refs log tree commit diff
path: root/iconv/gconv_conf.c
diff options
context:
space:
mode:
authorArjun Shankar <arjun@redhat.com>2018-09-25 15:13:15 +0200
committerArjun Shankar <arjun@redhat.com>2018-09-25 15:13:15 +0200
commit335a3b0a0d26313537eddfc26db14e33deecc433 (patch)
tree8c6ba407e589316f831254a826006337c1c1441f /iconv/gconv_conf.c
parent462d348caa16843594d8f23170ba7b635d2df220 (diff)
downloadglibc-335a3b0a0d26313537eddfc26db14e33deecc433.tar.gz
glibc-335a3b0a0d26313537eddfc26db14e33deecc433.tar.xz
glibc-335a3b0a0d26313537eddfc26db14e33deecc433.zip
Clean up iconv/gconv_int.h for unnecessary declarations
The variables __gconv_path_elem, __gconv_max_path_elem_len and function
__gconv_get_path declared in, as well as the type path_elem and macro
GCONV_NCHAR_GOAL defined in gconv_int.h are all used in only one iconv
compilation unit each. In addition, the extern declaration of the variable
__gconv_nmodules refers to a variable that does not exist any more.
Considering this, these symbols do not need to be exposed via a header file.

This patch removes the extern declarations from the header file and moves
the definitions to the compilation units where they are used.
Diffstat (limited to 'iconv/gconv_conf.c')
-rw-r--r--iconv/gconv_conf.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/iconv/gconv_conf.c b/iconv/gconv_conf.c
index f173cde71b..ce9f10f3af 100644
--- a/iconv/gconv_conf.c
+++ b/iconv/gconv_conf.c
@@ -38,6 +38,13 @@
 /* This is the default path where we look for module lists.  */
 static const char default_gconv_path[] = GCONV_PATH;
 
+/* Type to represent search path.  */
+struct path_elem
+{
+  const char *name;
+  size_t len;
+};
+
 /* The path elements, as determined by the __gconv_get_path function.
    All path elements end in a slash.  */
 struct path_elem *__gconv_path_elem;
@@ -420,7 +427,7 @@ read_conf_file (const char *filename, const char *directory, size_t dir_len,
 
 
 /* Determine the directories we are looking for data in.  */
-void
+static void
 __gconv_get_path (void)
 {
   struct path_elem *result;