about summary refs log tree commit diff
path: root/elf
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2019-12-02 14:53:16 +0100
committerFlorian Weimer <fweimer@redhat.com>2019-12-02 14:54:38 +0100
commit61a7c9df71ee4e6f94b56c20f0d37c6e17d5f284 (patch)
tree684a77afcbb0ae5e744077f9fd0f75488993fe46 /elf
parentdd67928700bc9b5954c93b29a6e0b0c4b279d454 (diff)
downloadglibc-61a7c9df71ee4e6f94b56c20f0d37c6e17d5f284.tar.gz
glibc-61a7c9df71ee4e6f94b56c20f0d37c6e17d5f284.tar.xz
glibc-61a7c9df71ee4e6f94b56c20f0d37c6e17d5f284.zip
elf/tst-dlopenfail: Disable --no-as-needed for tst-dlopenfailmod1.so
Otherwise, the shared object dependency which triggers the load
failure is dropped, invalidating the test.
Diffstat (limited to 'elf')
-rw-r--r--elf/Makefile7
1 files changed, 5 insertions, 2 deletions
diff --git a/elf/Makefile b/elf/Makefile
index 305bed2d38..f7adebec88 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -1602,8 +1602,11 @@ LDFLAGS-tst-finilazyfailmod.so = \
 $(objpfx)tst-dlopenfail: $(libdl)
 $(objpfx)tst-dlopenfail.out: \
   $(objpfx)tst-dlopenfailmod1.so $(objpfx)tst-dlopenfailmod2.so
-# Order matters here.  tst-dlopenfaillinkmod.so's soname ensures
-# a run-time loader failure.
+# Order matters here.  tst-dlopenfaillinkmod.so's soname ensures a
+# run-time loader failure.  --as-needed breaks this test because
+# nothing actually references tst-dlopenfailmod2.so (with its soname
+# tst-dlopenfail-missingmod.so).
+LDFLAGS-tst-dlopenfailmod1.so = -Wl,--no-as-needed
 $(objpfx)tst-dlopenfailmod1.so: \
   $(shared-thread-library) $(objpfx)tst-dlopenfaillinkmod.so
 LDFLAGS-tst-dlopenfaillinkmod.so = -Wl,-soname,tst-dlopenfail-missingmod.so