diff options
author | Jim Wilson <jimw@sifive.com> | 2019-01-13 15:48:09 -0800 |
---|---|---|
committer | Palmer Dabbelt <palmer@sifive.com> | 2019-02-13 14:25:00 -0800 |
commit | 85bd1ddbdfdfd13cfd06f7c367519b6ed3360843 (patch) | |
tree | b129acc357887fb5345ff240d4521ddb862630bf /elf/tst-unwind-main.c | |
parent | 107562682c8f6a5736a0a8257428c15a3c68a165 (diff) | |
download | glibc-85bd1ddbdfdfd13cfd06f7c367519b6ed3360843.tar.gz glibc-85bd1ddbdfdfd13cfd06f7c367519b6ed3360843.tar.xz glibc-85bd1ddbdfdfd13cfd06f7c367519b6ed3360843.zip |
RISC-V: Fix elfutils testsuite unwind failures.
The clone.S patch fixes 2 elfutils testsuite unwind failures, where the backtrace gets stuck repeating __thread_start until we hit the backtrace limit. This was confirmed by building and installing a patched glibc and then building elfutils and running its testsuite. Unfortunately, the testcase isn't working as expected and I don't know why. The testcase passes even when my clone.S patch is not installed. The testcase looks logically similarly to the elfutils testcases that are failing. Maybe there is a subtle difference in how the glibc unwinding works versus the elfutils unwinding? I don't have good gdb pthread support yet, so I haven't found a way to debug this. Anyways, I don't know if the testcase is useful or not. If the testcase isn't useful then maybe the clone.S patch is OK without a testcase? Jim [BZ #24040] * elf/Makefile (CFLAGS-tst-unwind-main.c): Add -DUSE_PTHREADS=0. * elf/tst-unwind-main.c: If USE_PTHEADS, include pthread.h and error.h (func): New. (main): If USE_PTHREADS, call pthread_create to run func. Otherwise call func directly. * nptl/Makefile (tests): Add tst-unwind-thread. (CFLAGS-tst-unwind-thread.c): Define. * nptl/tst-unwind-thread.c: New file. * sysdeps/unix/sysv/linux/riscv/clone.S (__thread_start): Mark ra as undefined.
Diffstat (limited to 'elf/tst-unwind-main.c')
-rw-r--r-- | elf/tst-unwind-main.c | 28 |
1 files changed, 25 insertions, 3 deletions
diff --git a/elf/tst-unwind-main.c b/elf/tst-unwind-main.c index 4089e7e907..0c345dc31f 100644 --- a/elf/tst-unwind-main.c +++ b/elf/tst-unwind-main.c @@ -20,19 +20,41 @@ #include <unistd.h> #include <support/test-driver.h> +#if USE_PTHREADS +# include <pthread.h> +# include <error.h> +#endif + static _Unwind_Reason_Code callback (struct _Unwind_Context *ctx, void *arg) { return _URC_NO_REASON; } -int -main (void) +static void * +func (void *a) { /* Arrange for this test to be killed if _Unwind_Backtrace runs into an endless loop. We cannot use the test driver because the complete call chain needs to be compiled with -funwind-tables so that - _Unwind_Backtrace is able to reach _start. */ + _Unwind_Backtrace is able to reach the start routine. */ alarm (DEFAULT_TIMEOUT); _Unwind_Backtrace (callback, 0); + return a; +} + +int +main (void) +{ +#if USE_PTHREADS + pthread_t thr; + int rc = pthread_create (&thr, NULL, &func, NULL); + if (rc) + error (1, rc, "pthread_create"); + rc = pthread_join (thr, NULL); + if (rc) + error (1, rc, "pthread_join"); +#else + func (NULL); +#endif } |