about summary refs log tree commit diff
path: root/elf/tst-stringtable.c
diff options
context:
space:
mode:
authorBen Woodard <woodard@redhat.com>2022-01-24 10:46:18 -0300
committerCarlos O'Donell <carlos@redhat.com>2022-03-29 17:02:36 -0400
commitb7f913c052ec1349a3f27e2302cc81380f67a218 (patch)
tree974e231d61b0eb7f86344b6f9471d6e92c9eddf2 /elf/tst-stringtable.c
parent1d1466e7c45a557e2426c650d6fab3c1b80162ec (diff)
downloadglibc-b7f913c052ec1349a3f27e2302cc81380f67a218.tar.gz
glibc-b7f913c052ec1349a3f27e2302cc81380f67a218.tar.xz
glibc-b7f913c052ec1349a3f27e2302cc81380f67a218.zip
elf: Fix runtime linker auditing on aarch64 (BZ #26643)
The rtld audit support show two problems on aarch64:

  1. _dl_runtime_resolve does not preserve x8, the indirect result
      location register, which might generate wrong result calls
      depending of the function signature.

  2. The NEON Q registers pushed onto the stack by _dl_runtime_resolve
     were twice the size of D registers extracted from the stack frame by
     _dl_runtime_profile.

While 2. might result in wrong information passed on the PLT tracing,
1. generates wrong runtime behaviour.

The aarch64 rtld audit support is changed to:

  * Both La_aarch64_regs and La_aarch64_retval are expanded to include
    both x8 and the full sized NEON V registers, as defined by the
    ABI.

  * dl_runtime_profile needed to extract registers saved by
    _dl_runtime_resolve and put them into the new correctly sized
    La_aarch64_regs structure.

  * The LAV_CURRENT check is change to only accept new audit modules
    to avoid the undefined behavior of not save/restore x8.

  * Different than other architectures, audit modules older than
    LAV_CURRENT are rejected (both La_aarch64_regs and La_aarch64_retval
    changed their layout and there are no requirements to support multiple
    audit interface with the inherent aarch64 issues).

  * A new field is also reserved on both La_aarch64_regs and
    La_aarch64_retval to support variant pcs symbols.

Similar to x86, a new La_aarch64_vector type to represent the NEON
register is added on the La_aarch64_regs (so each type can be accessed
directly).

Since LAV_CURRENT was already bumped to support bind-now, there is
no need to increase it again.

Checked on aarch64-linux-gnu.

Co-authored-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
(cherry picked from commit ce9a68c57c260c8417afc93972849ac9ad243ec4)

Resolved conflicts:
	NEWS
	elf/rtld.c
Diffstat (limited to 'elf/tst-stringtable.c')
0 files changed, 0 insertions, 0 deletions