summary refs log tree commit diff
path: root/elf/tst-big-note.c
diff options
context:
space:
mode:
authorPaul Pluzhnikov <ppluzhnikov@google.com>2018-05-05 18:08:27 -0700
committerPaul Pluzhnikov <ppluzhnikov@google.com>2018-05-05 18:08:27 -0700
commit0065aaaaae51cd60210ec3a7e13dddd8e01ffe2c (patch)
treefb1f587dbe38029797cdf5b3779b51b7cea3d680 /elf/tst-big-note.c
parentb289cd9db8286fa6c670104dd5dfcfc68d5d00d6 (diff)
downloadglibc-0065aaaaae51cd60210ec3a7e13dddd8e01ffe2c.tar.gz
glibc-0065aaaaae51cd60210ec3a7e13dddd8e01ffe2c.tar.xz
glibc-0065aaaaae51cd60210ec3a7e13dddd8e01ffe2c.zip
Fix BZ 20419. A PT_NOTE in a binary could be arbitratily large, so using
alloca for it may cause stack overflow.  If the note is larger than
__MAX_ALLOCA_CUTOFF, use dynamically allocated memory to read it in.

2018-05-05  Paul Pluzhnikov  <ppluzhnikov@google.com>

	[BZ #20419]
	* elf/dl-load.c (open_verify): Fix stack overflow.
	* elf/Makefile (tst-big-note): New test.
	* elf/tst-big-note-lib.S: New.
	* elf/tst-big-note.c: New.
Diffstat (limited to 'elf/tst-big-note.c')
-rw-r--r--elf/tst-big-note.c26
1 files changed, 26 insertions, 0 deletions
diff --git a/elf/tst-big-note.c b/elf/tst-big-note.c
new file mode 100644
index 0000000000..fcd2b0ed82
--- /dev/null
+++ b/elf/tst-big-note.c
@@ -0,0 +1,26 @@
+/* Bug 20419: test for stack overflow in elf/dl-load.c open_verify()
+   Copyright (C) 2018 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+/* This file must be run from within a directory called "elf".  */
+
+int main (int argc, char *argv[])
+{
+  /* Nothing to do here: merely linking against tst-big-note-lib.so triggers
+     the bug.  */
+  return 0;
+}