summary refs log tree commit diff
path: root/elf/tst-audit14.c
diff options
context:
space:
mode:
authorStafford Horne <shorne@gmail.com>2021-10-06 08:30:38 +0900
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2021-10-12 13:25:43 -0300
commit171ab1af562836dd9c56756922efb69eafa9eb5c (patch)
tree6059cb794604bc64859f82ac4a466fbfc9061c5a /elf/tst-audit14.c
parent4af6982e4c9fc465ffb7a54b794aaaa134241f05 (diff)
downloadglibc-171ab1af562836dd9c56756922efb69eafa9eb5c.tar.gz
glibc-171ab1af562836dd9c56756922efb69eafa9eb5c.tar.xz
glibc-171ab1af562836dd9c56756922efb69eafa9eb5c.zip
elf: Update audit tests to not depend on stdout
The tst-audit14, tst-audit15 and tst-audit16 tests all have audit
modules that write to stdout; the test reads from stdout to confirm
what was written.  This assumes the stdout is a file which is not the
case when run over ssh.

This patch updates the tests to use a post run cmp command to compare
the output against and .exp file.  This is similar to how many other
tests work and it fixes the stdout limitation.  Also, this means the
test code can be greatly simplified.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Diffstat (limited to 'elf/tst-audit14.c')
-rw-r--r--elf/tst-audit14.c21
1 files changed, 0 insertions, 21 deletions
diff --git a/elf/tst-audit14.c b/elf/tst-audit14.c
index c57c2184c3..13c14b1a92 100644
--- a/elf/tst-audit14.c
+++ b/elf/tst-audit14.c
@@ -16,30 +16,9 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#include <stdlib.h>
-#include <string.h>
-#include <support/check.h>
-#include <support/xstdio.h>
-
 static int
 do_test (void)
 {
-  /* Verify what the audit module has written.  This test assumes that
-     standard output has been redirected to a regular file.  */
-  FILE *fp = xfopen ("/dev/stdout", "r");
-
-  char *buffer = NULL;
-  size_t buffer_length = 0;
-  size_t line_length = xgetline (&buffer, &buffer_length, fp);
-  const char *message = "info: tst-auditlogmod-1.so loaded\n";
-  TEST_COMPARE_BLOB (message, strlen (message), buffer, line_length);
-
-  /* No more audit module output.  */
-  line_length = xgetline (&buffer, &buffer_length, fp);
-  TEST_COMPARE_BLOB ("", 0, buffer, line_length);
-
-  free (buffer);
-  xfclose (fp);
   return 0;
 }