diff options
| author | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2020-12-31 13:59:38 +0000 |
|---|---|---|
| committer | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2021-05-11 17:16:37 +0100 |
| commit | 572bd547d57a39b6cf0ea072545dc4048921f4c3 (patch) | |
| tree | 6a199fb5aebcced8309dc62206b01ab428bf524f /elf/dl-open.c | |
| parent | 9d0e30329c23b5ad736fda3f174208c25970dbce (diff) | |
| download | glibc-572bd547d57a39b6cf0ea072545dc4048921f4c3.tar.gz glibc-572bd547d57a39b6cf0ea072545dc4048921f4c3.tar.xz glibc-572bd547d57a39b6cf0ea072545dc4048921f4c3.zip | |
elf: Fix DTV gap reuse logic [BZ #27135]
For some reason only dlopen failure caused dtv gaps to be reused. It is possible that the intent was to never reuse modids for a different module, but after dlopen failure all gaps are reused not just the ones caused by the unfinished dlopened. So the code has to handle reused modids already which seems to work, however the data races at thread creation and tls access (see bug 19329 and bug 27111) may be more severe if slots are reused so this is scheduled after those fixes. I think fixing the races are not simpler if reuse is disallowed and reuse has other benefits, so set GL(dl_tls_dtv_gaps) whenever entries are removed from the middle of the slotinfo list. The value does not have to be correct: incorrect true value causes the next modid query to do a slotinfo walk, incorrect false will leave gaps and new entries are added at the end. Fixes bug 27135. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'elf/dl-open.c')
| -rw-r--r-- | elf/dl-open.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/elf/dl-open.c b/elf/dl-open.c index bb79ef00f1..0887fc5cc5 100644 --- a/elf/dl-open.c +++ b/elf/dl-open.c @@ -890,16 +890,6 @@ no more namespaces available for dlmopen()")); state if relocation failed, for example. */ if (args.map) { - /* Maybe some of the modules which were loaded use TLS. - Since it will be removed in the following _dl_close call - we have to mark the dtv array as having gaps to fill the - holes. This is a pessimistic assumption which won't hurt - if not true. There is no need to do this when we are - loading the auditing DSOs since TLS has not yet been set - up. */ - if ((mode & __RTLD_AUDIT) == 0) - GL(dl_tls_dtv_gaps) = true; - _dl_close_worker (args.map, true); /* All l_nodelete_pending objects should have been deleted |