about summary refs log tree commit diff
path: root/elf/check-execstack.c
diff options
context:
space:
mode:
authorAndreas Schwab <schwab@linux-m68k.org>2011-01-13 16:21:55 -0500
committerUlrich Drepper <drepper@gmail.com>2011-01-13 16:21:55 -0500
commit68dc949774cb651d53541df4abdc60327f7e096b (patch)
treea1385c2904cb736cca63ce8de24bdaf345b4a0bc /elf/check-execstack.c
parent8cf8ce1702c354a8266e3cfa6ab54c2467d1873f (diff)
downloadglibc-68dc949774cb651d53541df4abdc60327f7e096b.tar.gz
glibc-68dc949774cb651d53541df4abdc60327f7e096b.tar.xz
glibc-68dc949774cb651d53541df4abdc60327f7e096b.zip
Fix check-execstack test
Diffstat (limited to 'elf/check-execstack.c')
-rw-r--r--elf/check-execstack.c20
1 files changed, 10 insertions, 10 deletions
diff --git a/elf/check-execstack.c b/elf/check-execstack.c
index 64353751e9..96e481208d 100644
--- a/elf/check-execstack.c
+++ b/elf/check-execstack.c
@@ -26,7 +26,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
-#include <stackinfo.h>
+#include "check-execstack.h"
 
 
 #ifdef BITS
@@ -92,8 +92,13 @@ AB(handle_file) (const char *fname, int fd)
 	return 0;
       }
 
-  printf ("%s: no PT_GNU_STACK entry\n", fname);
-  return 1;
+  if (DEFAULT_STACK_PERMS & PF_X)
+    {
+      printf ("%s: no PT_GNU_STACK entry\n", fname);
+      return 1;
+    }
+
+  return 0;
 }
 
 # undef BITS
@@ -151,13 +156,8 @@ main (int argc, char *argv[])
   int cnt;
   int result = 0;
 
-  /* We can return successfully, i.e., not fail, if PF_X isn't present.  If it
-   * is present then check for the GNU_STACK header.  */
-  if (DEFAULT_STACK_PERMS & PF_X)
-    {
-      for (cnt = 1; cnt < argc; ++cnt)
-	result |= handle_file (argv[cnt]);
-     }
+  for (cnt = 1; cnt < argc; ++cnt)
+    result |= handle_file (argv[cnt]);
   return result;
 }
 #endif