diff options
author | Jim Wilson <jimw@sifive.com> | 2019-01-13 15:48:09 -0800 |
---|---|---|
committer | Palmer Dabbelt <palmer@sifive.com> | 2019-02-13 14:25:00 -0800 |
commit | 85bd1ddbdfdfd13cfd06f7c367519b6ed3360843 (patch) | |
tree | b129acc357887fb5345ff240d4521ddb862630bf /elf/Makefile | |
parent | 107562682c8f6a5736a0a8257428c15a3c68a165 (diff) | |
download | glibc-85bd1ddbdfdfd13cfd06f7c367519b6ed3360843.tar.gz glibc-85bd1ddbdfdfd13cfd06f7c367519b6ed3360843.tar.xz glibc-85bd1ddbdfdfd13cfd06f7c367519b6ed3360843.zip |
RISC-V: Fix elfutils testsuite unwind failures.
The clone.S patch fixes 2 elfutils testsuite unwind failures, where the backtrace gets stuck repeating __thread_start until we hit the backtrace limit. This was confirmed by building and installing a patched glibc and then building elfutils and running its testsuite. Unfortunately, the testcase isn't working as expected and I don't know why. The testcase passes even when my clone.S patch is not installed. The testcase looks logically similarly to the elfutils testcases that are failing. Maybe there is a subtle difference in how the glibc unwinding works versus the elfutils unwinding? I don't have good gdb pthread support yet, so I haven't found a way to debug this. Anyways, I don't know if the testcase is useful or not. If the testcase isn't useful then maybe the clone.S patch is OK without a testcase? Jim [BZ #24040] * elf/Makefile (CFLAGS-tst-unwind-main.c): Add -DUSE_PTHREADS=0. * elf/tst-unwind-main.c: If USE_PTHEADS, include pthread.h and error.h (func): New. (main): If USE_PTHREADS, call pthread_create to run func. Otherwise call func directly. * nptl/Makefile (tests): Add tst-unwind-thread. (CFLAGS-tst-unwind-thread.c): Define. * nptl/tst-unwind-thread.c: New file. * sysdeps/unix/sysv/linux/riscv/clone.S (__thread_start): Mark ra as undefined.
Diffstat (limited to 'elf/Makefile')
-rw-r--r-- | elf/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/elf/Makefile b/elf/Makefile index 5c625b89fa..faec577d1c 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1512,4 +1512,4 @@ $(objpfx)tst-big-note: $(objpfx)tst-big-note-lib.so $(objpfx)tst-unwind-ctor: $(objpfx)tst-unwind-ctor-lib.so -CFLAGS-tst-unwind-main.c += -funwind-tables +CFLAGS-tst-unwind-main.c += -funwind-tables -DUSE_PTHREADS=0 |