diff options
| author | Carlos O'Donell <carlos@redhat.com> | 2014-11-06 15:48:44 -0500 |
|---|---|---|
| committer | Carlos O'Donell <carlos@redhat.com> | 2014-11-06 15:48:44 -0500 |
| commit | da53d6dbc28d2a90d6e14dd661e68611c3b741cf (patch) | |
| tree | 8d8a5a7c54d96c6a34a4780bd83a648ea073368a /elf/Makefile | |
| parent | 9cf27b8d09aab26bd4693b10f281d64da779da83 (diff) | |
| download | glibc-da53d6dbc28d2a90d6e14dd661e68611c3b741cf.tar.gz glibc-da53d6dbc28d2a90d6e14dd661e68611c3b741cf.tar.xz glibc-da53d6dbc28d2a90d6e14dd661e68611c3b741cf.zip | |
Run check-localpltk/textrel/execstack over ld.so.
For maximum paranoia we run ld.so through the normal set of tests for all of the shared libraries. This includes running ld.so through check-localplt, check-textrel, and check-execstack. While none of these should trigger any failures given the way ld.so is built, it might possibly fail if a developer does something wrong. This paranoia was triggered by a discussion over the use of __strcpy vs. strcpy [1] and if the symbol could leak and use the libc.so version. The check-localplt test fails right away because localplt.data needs updating for all arches. By default we add 6 new symbols: __tls_get_addr, __libc_memalign, malloc, calloc, realloc and free. Other machines like i386, power, and s390 require some different symbol sets e.g. ___tls_get_addr vs. __tls_get_addr for i386. Verified for i386 Verified for x86_64 Verified for ppc32 Verified for ppc64 Verified for ppc64le Verified for arm Verified for aarch64 Verified for s390 Verified for s390x Guessed for alpha Guessed for ia64 Guessed for m68k Guessed for microblaze Guessed for sparc32 Guessed for sparc64 Defaults for sh Defaults for mips Defaults for hppa Defaults for tile Machine manintainers notified to double check the data used in localplt.data. [1] https://sourceware.org/ml/libc-alpha/2014-10/msg00548.html
Diffstat (limited to 'elf/Makefile')
| -rw-r--r-- | elf/Makefile | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/elf/Makefile b/elf/Makefile index 94074f3e34..34f0b1fb83 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -904,7 +904,7 @@ CFLAGS-tst-pie2.c += $(pie-ccflag) $(objpfx)tst-pie1: $(objpfx)tst-piemod1.so ifeq (yes,$(build-shared)) -all-built-dso := $(common-objpfx)libc.so \ +all-built-dso := $(common-objpfx)elf/ld.so $(common-objpfx)libc.so \ $(filter-out $(common-objpfx)linkobj/libc.so, \ $(sort $(wildcard $(addprefix $(common-objpfx), \ */lib*.so \ @@ -963,6 +963,7 @@ common-generated += $(all-built-dso:$(common-objpfx)%=%.jmprel) localplt-built-dso := $(addprefix $(common-objpfx),\ libc.so \ + elf/ld.so \ math/libm.so \ rt/librt.so \ dlfcn/libdl.so \ |