diff options
author | Adhemerval Zanella <adhemerval.zanella@linaro.com> | 2015-10-14 12:15:46 -0300 |
---|---|---|
committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2015-12-02 14:45:50 -0200 |
commit | d0e3ffb7a58854248f1d5e737610d50cd0a60f46 (patch) | |
tree | 557241d96a55aa279e04078b60756843ba385f97 /debug/stack_chk_fail_local.c | |
parent | 7635a88d320c665defd44085d3b9031d673fe1ee (diff) | |
download | glibc-d0e3ffb7a58854248f1d5e737610d50cd0a60f46.tar.gz glibc-d0e3ffb7a58854248f1d5e737610d50cd0a60f46.tar.xz glibc-d0e3ffb7a58854248f1d5e737610d50cd0a60f46.zip |
nptl: Fix racy pipe closing in tst-cancel{20,21}
The tst-cancel20 open two pipes and creates a thread which blocks reading the first pipe. It then issues a signal to activate the signal handler which in turn blocks reading the second pipe end. Finally the cancellation cleanup-up handlers are tested by first closing the all the pipes ends and issuing a pthread_cancel. The tst-cancel21 have a similar behavior, but use an extra fork after the test itself. The race condition occurs if the cancellation handling acts after the pipe close: in this case read will return EOF (indicating side-effects) and thus the cancellation must not act. However current GLIBC cancellation behavior acts regardless the syscalls returns with sid-effects. This patch adjust the test by moving the pipe closing after the cancellation handling. This avoid spurious cancellation if the case of the race described. Checked on x86_64 and i386. * nptl/tst-cancel20.c (do_one_test): Move the pipe closing after pthread_join. * nptl/tst-cancel21.c (tf): Likewise.
Diffstat (limited to 'debug/stack_chk_fail_local.c')
0 files changed, 0 insertions, 0 deletions