about summary refs log tree commit diff
path: root/assert
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2016-04-27 11:51:01 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2016-04-29 19:25:17 -0300
commitb65b205fbcabbb02463e31df17f5cabf7556f892 (patch)
treecb3f45139b4ffe2df81409cf4c28cc6e47f81a9f /assert
parent0cb313f7cb0e418b3d56f3a2ac69790522ab825d (diff)
downloadglibc-b65b205fbcabbb02463e31df17f5cabf7556f892.tar.gz
glibc-b65b205fbcabbb02463e31df17f5cabf7556f892.tar.xz
glibc-b65b205fbcabbb02463e31df17f5cabf7556f892.zip
libio: Fix fmemopen append mode failure (BZ# 20012)
The fmemopen implementation does not account the file position correctly in
append mode. The following example shows the failure:

===
int main ()
{
  char buf[10] = "test";
  FILE *fp = fmemopen (buf, 10, "a+");
  fseek (fp, 0, SEEK_SET);

  int gr;
  if ((gr = getc (fp)) != 't' ||
      (gr = getc (fp)) != 'e' ||
      (gr = getc (fp)) != 's' ||
      (gr = getc (fp)) != 't' ||
      (gr = getc (fp)) != EOF)
    {
      printf ("%s: getc failed returned %i\n", __FUNCTION__, gr);
      return 1;
    }

  return 0;
}
===

This is due both how read and write operation update the buffer position,
taking in consideration buffer lenght instead of maximum position defined
by the open mode.  This patch fixes it and also fixes fseek not returning
EINVAL for invalid whence modes.

Tested on x86_64 and i686.

	[BZ #20012]
	* libio/fmemopen.c (fmemopen_read): Use buffer maximum position, not
	length to calculate the buffer to read.
	(fmemopen_write): Set the buffer position based on bytes written.
	(fmemopen_seek): Return EINVAL for invalid whence modes.
Diffstat (limited to 'assert')
0 files changed, 0 insertions, 0 deletions