about summary refs log tree commit diff
path: root/Makefile
diff options
context:
space:
mode:
authorSiddhesh Poyarekar <siddhesh@redhat.com>2015-05-19 06:36:29 +0530
committerSiddhesh Poyarekar <siddhesh@redhat.com>2015-05-19 06:36:29 +0530
commit99db95db37b4fd95986fadb263e4180b7381d10d (patch)
treec317841c54f247ba36cd46dc42acc6e441652f33 /Makefile
parent920d70128baa41ce6ce3b1b4771fe912f8d1691a (diff)
downloadglibc-99db95db37b4fd95986fadb263e4180b7381d10d.tar.gz
glibc-99db95db37b4fd95986fadb263e4180b7381d10d.tar.xz
glibc-99db95db37b4fd95986fadb263e4180b7381d10d.zip
Succeed if make check does not report any errors
The conditional that evaluates if there are any FAILed test cases
currently always fails, since we ensure it fails if we find any
unexpected results in tests.sum and it would obviously fail if it does
not find failed results in tests.sum.  This patch fixes this by simply
inverting the result of the egrep, i.e. succeed if egrep fails (to
find failed results) and fail if it succeeds.

Tested with 'make subdirs=localedata check' and 'make subdirs=locale
check' where all tests succeed and with 'make subdirs=elf check' where
a couple of tests fail for me.

	 * Makefile (summarize-tests): Fix return value on success.
Diffstat (limited to 'Makefile')
-rw-r--r--Makefile2
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index 7edf517724..658ccfa037 100644
--- a/Makefile
+++ b/Makefile
@@ -320,7 +320,7 @@ define summarize-tests
 @egrep -v '^(PASS|XFAIL):' $(objpfx)$1 || true
 @echo "Summary of test results$2:"
 @sed 's/:.*//' < $(objpfx)$1 | sort | uniq -c
-@egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1 && false
+@! egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1
 endef
 
 tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))