diff options
| author | Alan Modra <amodra@gmail.com> | 2013-08-17 18:48:36 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2013-10-04 10:41:46 +0930 |
| commit | 466b03933234017473c12dd1d92bda5e7fe49df7 (patch) | |
| tree | b70778371ad8c8e5a1ab77dee110d8711618abfd /ChangeLog | |
| parent | 3be87c77d24c4456ccca4034363b6d1814cd0c84 (diff) | |
| download | glibc-466b03933234017473c12dd1d92bda5e7fe49df7.tar.gz glibc-466b03933234017473c12dd1d92bda5e7fe49df7.tar.xz glibc-466b03933234017473c12dd1d92bda5e7fe49df7.zip | |
PowerPC LE memchr and memrchr
http://sourceware.org/ml/libc-alpha/2013-08/msg00105.html Like strnlen, memchr and memrchr had a number of defects fixed by this patch as well as adding little-endian support. The first one I noticed was that the entry to the main loop needlessly checked for "are we done yet?" when we know the size is large enough that we can't be done. The second defect I noticed was that the main loop count was wrong, which in turn meant that the small loop needed to handle an extra word. Thirdly, there is nothing to say that the string can't wrap around zero, except of course that we'd normally hit a segfault on trying to read from address zero. Fixing that simplified a number of places: - /* Are we done already? */ - addi r9,r8,8 - cmpld r9,r7 - bge L(null) becomes + cmpld r8,r7 + beqlr However, the exit gets an extra test because I test for being on the last word then if so whether the byte offset is less than the end. Overall, the change is a win. Lastly, memrchr used the wrong cache hint. * sysdeps/powerpc/powerpc64/power7/memchr.S: Replace rlwimi with insrdi. Make better use of reg selection to speed exit slightly. Schedule entry path a little better. Remove useless "are we done" checks on entry to main loop. Handle wrapping around zero address. Correct main loop count. Handle single left-over word from main loop inline rather than by using loop_small. Remove extra word case in loop_small caused by wrong loop count. Add little-endian support. * sysdeps/powerpc/powerpc32/power7/memchr.S: Likewise. * sysdeps/powerpc/powerpc64/power7/memrchr.S: Likewise. Use proper cache hint. * sysdeps/powerpc/powerpc32/power7/memrchr.S: Likewise. * sysdeps/powerpc/powerpc64/power7/rawmemchr.S: Add little-endian support. Avoid rlwimi. * sysdeps/powerpc/powerpc32/power7/rawmemchr.S: Likewise.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index cd54976bcf..42607ea822 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,23 @@ 2013-10-04 Alan Modra <amodra@gmail.com> + * sysdeps/powerpc/powerpc64/power7/memchr.S: Replace rlwimi with + insrdi. Make better use of reg selection to speed exit slightly. + Schedule entry path a little better. Remove useless "are we done" + checks on entry to main loop. Handle wrapping around zero address. + Correct main loop count. Handle single left-over word from main + loop inline rather than by using loop_small. Remove extra word + case in loop_small caused by wrong loop count. Add little-endian + support. + * sysdeps/powerpc/powerpc32/power7/memchr.S: Likewise. + * sysdeps/powerpc/powerpc64/power7/memrchr.S: Likewise. Use proper + cache hint. + * sysdeps/powerpc/powerpc32/power7/memrchr.S: Likewise. + * sysdeps/powerpc/powerpc64/power7/rawmemchr.S: Add little-endian + support. Avoid rlwimi. + * sysdeps/powerpc/powerpc32/power7/rawmemchr.S: Likewise. + +2013-10-04 Alan Modra <amodra@gmail.com> + * sysdeps/powerpc/powerpc64/memset.S: Replace rlwimi with insrdi. Formatting. * sysdeps/powerpc/powerpc64/power4/memset.S: Likewise. |