diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2016-05-12 16:46:55 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2016-05-12 16:46:55 +0000 |
| commit | ca927ec4c23f47b559e8e2d493caaad9c13092f6 (patch) | |
| tree | 58b880b3ebbee822878f41f9a7ef6426e285f942 /ChangeLog | |
| parent | a8c5a2a9521e105da6e96eaf4029b8e4d595e4f5 (diff) | |
| download | glibc-ca927ec4c23f47b559e8e2d493caaad9c13092f6.tar.gz glibc-ca927ec4c23f47b559e8e2d493caaad9c13092f6.tar.xz glibc-ca927ec4c23f47b559e8e2d493caaad9c13092f6.zip | |
conformtest: Do not expect S_IF* in fcntl.h.
The conform/ tests for fcntl.h are failing for XPG3 and XPG4 because of missing S_IFSOCK. This is a case of a bogus test. The relevant wording requiring such constants is, in current POSIX (and this requirement dates back as far as XPG4), "The <fcntl.h> header shall define the symbolic constants for file modes for use as values of mode_t as described in <sys/stat.h>.". Note that this is *file modes* not *file types*. That makes sense, since the point is presumably for use with functions such as open that are declared in fcntl.h, where file modes are relevant but file types aren't. So this patch removes all those spurious S_IF* expectations for fcntl.h (the macros are generally still *allowed* through the permission to make everything from sys/stat.h visible). Tested for x86_64 and x86. * conform/data/fcntl.h-data [!POSIX] (S_IFMT): Do not expect. [!POSIX] (S_IFBLK): Likewise. [!POSIX] (S_IFCHR): Likewise. [!POSIX] (S_IFIFO): Likewise. [!POSIX] (S_IFREG): Likewise. [!POSIX] (S_IFDIR): Likewise. [!POSIX] (S_IFLNK): Likewise. [!POSIX] (S_IFSOCK): Likewise. * conform/Makefile (test-xfail-XPG3/fcntl.h/conform): Remove variable. (test-xfail-XPG4/fcntl.h/conform): Likewise.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index a7dd3a72ff..b85a2938ea 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,17 @@ +2016-05-12 Joseph Myers <joseph@codesourcery.com> + + * conform/data/fcntl.h-data [!POSIX] (S_IFMT): Do not expect. + [!POSIX] (S_IFBLK): Likewise. + [!POSIX] (S_IFCHR): Likewise. + [!POSIX] (S_IFIFO): Likewise. + [!POSIX] (S_IFREG): Likewise. + [!POSIX] (S_IFDIR): Likewise. + [!POSIX] (S_IFLNK): Likewise. + [!POSIX] (S_IFSOCK): Likewise. + * conform/Makefile (test-xfail-XPG3/fcntl.h/conform): Remove + variable. + (test-xfail-XPG4/fcntl.h/conform): Likewise. + 2016-05-12 Wilco Dijkstra <wdijkstr@arm.com> * sysdeps/aarch64/memset.S (__memset): |