diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2018-02-26 18:38:01 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2018-02-26 18:38:01 +0000 |
| commit | f54d8f735ab7647713b4f8e63282bd7a920234e1 (patch) | |
| tree | 374f4febfe49ae5575b78c7b5370875cdb449e3d /ChangeLog | |
| parent | 20602c72fa54bc0923314820ec8148186096bf3b (diff) | |
| download | glibc-f54d8f735ab7647713b4f8e63282bd7a920234e1.tar.gz glibc-f54d8f735ab7647713b4f8e63282bd7a920234e1.tar.xz glibc-f54d8f735ab7647713b4f8e63282bd7a920234e1.zip | |
Fix another -Os strcoll build issue.
While there are now clean -Os build and test results on x86_64 (given my patch <https://sourceware.org/ml/libc-alpha/2018-02/msg00602.html>, pending review), testing with -Os with build-many-glibcs.py shows the build is still failing with -Os everywhere except for x86_64, x86 and s390x. There are a variety of different build failures, but the most common seem to be in strcoll / wcscoll, similar to existing such cases where DIAG_* are used to disable -Wmaybe-uninitialized. There are various different failures even within those functions. This patch fixes one particular case that seems quite common, where the warning appears at the declarations of seq1 and seq2. Tested with build-many-glibcs.py that this fixes the -Os build for aarch64-linux-gnu with GCC 7. * string/strcoll_l.c: Include <libc-diag.h>. (STRCOLL): Ignore -Wmaybe-uninitialized for -Os around declarations of seq1 and seq2.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index f7e7204c4f..a556c3bf7a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2018-02-26 Joseph Myers <joseph@codesourcery.com> + * string/strcoll_l.c: Include <libc-diag.h>. + (STRCOLL): Ignore -Wmaybe-uninitialized for -Os around + declarations of seq1 and seq2. + [BZ #15105] * stdlib/atoi.c (atoi): Use libc_hidden_def. * include/stdlib.h [!_ISOMAC] (atoi): Use libc_hidden_proto. |