diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2015-06-23 16:01:54 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2015-06-23 16:01:54 +0000 |
| commit | 718d34a309493f8697ff9a8fefcbacbba12a2ccd (patch) | |
| tree | 314b1f34149f46e8d8ed2a0cd3eb107fedf9fef1 /ChangeLog | |
| parent | b59549574efeeecf124de05c9183c120eaaa56f0 (diff) | |
| download | glibc-718d34a309493f8697ff9a8fefcbacbba12a2ccd.tar.gz glibc-718d34a309493f8697ff9a8fefcbacbba12a2ccd.tar.xz glibc-718d34a309493f8697ff9a8fefcbacbba12a2ccd.zip | |
Fix csqrt spurious underflows (bug 18371).
The csqrt implementations in glibc can cause spurious underflows in some cases as a side-effect of the scaling for large arguments (when underflow is correct for the square root of the argument that was scaled down to avoid overflow, but not for the original argument). This patch arranges to avoid the underflowing intermediate computation (eliminating a multiplication in 0.5 in the problem cases where a subsequent scaling by 2 would follow). Tested for x86_64 and x86 and ulps updated accordingly (only needed for x86). [BZ #18371] * math/s_csqrt.c (__csqrt): Avoid multiplication by 0.5 where intermediate but not final result might underflow. * math/s_csqrtf.c (__csqrtf): Likewise. * math/s_csqrtl.c (__csqrtl): Likewise. * math/auto-libm-test-in: Add more tests of csqrt. * math/auto-libm-test-out: Regenerated. * sysdeps/i386/fpu/libm-test-ulps: Update.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index a7f879af23..0c7710076d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,14 @@ 2015-06-23 Joseph Myers <joseph@codesourcery.com> + [BZ #18371] + * math/s_csqrt.c (__csqrt): Avoid multiplication by 0.5 where + intermediate but not final result might underflow. + * math/s_csqrtf.c (__csqrtf): Likewise. + * math/s_csqrtl.c (__csqrtl): Likewise. + * math/auto-libm-test-in: Add more tests of csqrt. + * math/auto-libm-test-out: Regenerated. + * sysdeps/i386/fpu/libm-test-ulps: Update. + [BZ #18219] * sysdeps/ieee754/dbl-64/e_exp2.c (__ieee754_exp2): Reduce threshold on absolute value of exponent for which scaling is used. |