diff options
| author | Petr Baudis <pasky@suse.cz> | 2009-07-16 10:10:10 -0700 |
|---|---|---|
| committer | Ulrich Drepper <drepper@redhat.com> | 2009-07-16 10:10:10 -0700 |
| commit | 137028b4d7e50f71906c1656c27079eac5a1d085 (patch) | |
| tree | 61b121088c68e50ff2483cd15675729cf3c337e7 /ChangeLog | |
| parent | 50158f95525ca59459a90f2a7bc65ceb892a0807 (diff) | |
| download | glibc-137028b4d7e50f71906c1656c27079eac5a1d085.tar.gz glibc-137028b4d7e50f71906c1656c27079eac5a1d085.tar.xz glibc-137028b4d7e50f71906c1656c27079eac5a1d085.zip | |
Fix lock handling in memory hander of nscd.
The commit 20e498bd removes the pthread_mutex_rdlock() calls, but not the corresponding pthread_mutex_unlock() calls. Also, the database lock is never unlocked in one branch of the mempool_alloc() if. I think unreproducible random assert(dh->usable) crashes in prune_cache() were caused by this. But an easy way to make nscd threads hang with the broken locking was.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index a81c5b46fb..37f20a4b8b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2009-07-16 Petr Baudis <pasky@suse.cz> + + * nscd/mem.c (mempool_alloc): Fix unlock missing in the else branch. + * nscd/aicache.c: Remove bogus db->lock unlock. + * nscd/grpcache.c: Likewise. + * nscd/hstcache.c: Likewise. + * nscd/initgrcache.c: Likewise. + * nscd/pwdcache.c: Likewise. + * nscd/servicescache.c: Likewise. + 2009-07-16 Ulrich Drepper <drepper@redhat.com> * nscd/cache.c (cache_add): Use atomic_compare_and_exchange_bool_rel @@ -5,6 +15,7 @@ is written before the list head update. Patch by Andreas Schwab <aschwab@redhat.com>. +2009-07-16 Ulrich Drepper <drepper@redhat.com> Jakub Jelinek <jakub@redhat.com> * malloc/malloc.c [ATOMIC_FASTBINS] (_int_free): Make check for |