diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2015-05-22 17:09:36 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2015-05-22 17:09:36 +0000 |
| commit | cf06a4e3579d834c3330184c4ff127c98bc00fcc (patch) | |
| tree | 8021cc34ee92db51ed9075a719e517a0a79458b3 /ChangeLog | |
| parent | 7348824c39c45d401f62f724ecad4e3479180578 (diff) | |
| download | glibc-cf06a4e3579d834c3330184c4ff127c98bc00fcc.tar.gz glibc-cf06a4e3579d834c3330184c4ff127c98bc00fcc.tar.xz glibc-cf06a4e3579d834c3330184c4ff127c98bc00fcc.zip | |
Fix pathconf basename namespace (bug 18444).
pathconf (sysdeps/unix/sysv/linux/pathconf.c) uses basename. But pathconf is in POSIX back to 1990 while basename is only reserved with external linkage in those standards including XPG functions. This patch fixes this namespace issue in the usual way, renaming basename to __basename and making it into a weak alias. Tested for x86_64 and x86 (testsuite, and that disassembly of installed shared libraries is unchanged by the patch). [BZ #18444] * string/basename.c (basename): Rename to __basename and define as weak alias of __basename. Use libc_hidden_weak. * include/string.h (__basename): Declare. Use libc_hidden_proto. * sysdeps/unix/sysv/linux/pathconf.c (distinguish_extX): Call __basename instead of basename. * conform/Makefile (test-xfail-POSIX2008/unistd.h/linknamespace): Remove variable. (test-xfail-XOPEN2K8/unistd.h/linknamespace): Likewise.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 27267b1f22..6a44067db4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2015-05-22 Joseph Myers <joseph@codesourcery.com> + + [BZ #18444] + * string/basename.c (basename): Rename to __basename and define as + weak alias of __basename. Use libc_hidden_weak. + * include/string.h (__basename): Declare. Use libc_hidden_proto. + * sysdeps/unix/sysv/linux/pathconf.c (distinguish_extX): Call + __basename instead of basename. + * conform/Makefile (test-xfail-POSIX2008/unistd.h/linknamespace): + Remove variable. + (test-xfail-XOPEN2K8/unistd.h/linknamespace): Likewise. + 2015-05-18 Florian Weimer <fweimer@redhat.com> * libio/libioP.h (_IO_MEMBER_TYPE, _IO_CAST_FIELD_ACCESS) |