diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2019-01-21 11:35:18 -0800 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2019-01-21 11:35:34 -0800 |
commit | c7c54f65b080affb87a1513dee449c8ad6143c8b (patch) | |
tree | 7843555220fda4dbbe023b2035a8de081810128a /ChangeLog | |
parent | ee915088a0231cd421054dbd8abab7aadf331153 (diff) | |
download | glibc-c7c54f65b080affb87a1513dee449c8ad6143c8b.tar.gz glibc-c7c54f65b080affb87a1513dee449c8ad6143c8b.tar.xz glibc-c7c54f65b080affb87a1513dee449c8ad6143c8b.zip |
x86-64 strncpy: Properly handle the length parameter [BZ# 24097]
On x32, the size_t parameter may be passed in the lower 32 bits of a 64-bit register with the non-zero upper 32 bits. The string/memory functions written in assembly can only use the lower 32 bits of a 64-bit register as length or must clear the upper 32 bits before using the full 64-bit register for length. This pach fixes strncpy for x32. Tested on x86-64 and x32. On x86-64, libc.so is the same with and withou the fix. [BZ# 24097] CVE-2019-6488 * sysdeps/x86_64/multiarch/strcpy-avx2.S: Use RDX_LP for length. * sysdeps/x86_64/multiarch/strcpy-sse2-unaligned.S: Likewise. * sysdeps/x86_64/multiarch/strcpy-ssse3.S: Likewise. * sysdeps/x86_64/x32/Makefile (tests): Add tst-size_t-strncpy. * sysdeps/x86_64/x32/tst-size_t-strncpy.c: New file.
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 7be0a2e81e..a0412f7a3e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,16 @@ [BZ# 24097] CVE-2019-6488 + * sysdeps/x86_64/multiarch/strcpy-avx2.S: Use RDX_LP for length. + * sysdeps/x86_64/multiarch/strcpy-sse2-unaligned.S: Likewise. + * sysdeps/x86_64/multiarch/strcpy-ssse3.S: Likewise. + * sysdeps/x86_64/x32/Makefile (tests): Add tst-size_t-strncpy. + * sysdeps/x86_64/x32/tst-size_t-strncpy.c: New file. + +2019-01-21 H.J. Lu <hongjiu.lu@intel.com> + + [BZ# 24097] + CVE-2019-6488 * sysdeps/x86_64/multiarch/strcmp-avx2.S: Use RDX_LP for length. * sysdeps/x86_64/multiarch/strcmp-sse42.S: Likewise. * sysdeps/x86_64/strcmp.S: Likewise. |