about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorBrooks Moses <bmoses@google.com>2013-10-03 10:38:14 -0700
committerBrooks Moses <bmoses@google.com>2013-10-03 10:38:14 -0700
commit5f855e3598a576c35e54623a13b256f3e87fcd4d (patch)
treeba77026f236ca40b764798e0d70001a3fcff58cd /ChangeLog
parentb7f2d27dbd85f6a0966dc389ad4f8205085b7ae8 (diff)
downloadglibc-5f855e3598a576c35e54623a13b256f3e87fcd4d.tar.gz
glibc-5f855e3598a576c35e54623a13b256f3e87fcd4d.tar.xz
glibc-5f855e3598a576c35e54623a13b256f3e87fcd4d.zip
Fix erroneous (and circular) implied pattern rule for linkobj/libc.so.
[BZ #15915] As described in the bug, the pattern rule for lib%.so files
in Makerules includes linkobj/libc.so as a dependency.  However, the
explicit rule for linkobj/libc.so is in the top-level Makefile.

Thus, the subdirectory makefiles that include Makerules end up with an
erroneous makefile pattern rule for linkobj/libc.so that includes
itself as a dependency.  The result is make warnings whenever rules
for other .so files are resolved -- and, on occasion, actual makefile
failures when a race condition causes the implicit rule to actually be
used.

This patch moves the explicit rules for linkobj/libc.so into Makerules
to clear up this problem.  It also elaborates a couple of comments
that I'd initially found confusing.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog6
1 files changed, 6 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index beba952cb4..12c2417679 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-10-03  Brooks Moses  <bmoses@google.com>
+
+	[BZ #15915]
+	* Makefile (linkobj/libc_pic.a, linkobj/libc.so): Move rules to...
+	* Makerules: ...here, and adjust associated comments.
+
 2013-10-02  Will Newton  <will.newton@linaro.org>
 
 	* malloc/Makefile: Add tst-pvalloc.