diff options
author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2016-12-15 18:27:10 +0000 |
---|---|---|
committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2016-12-16 11:30:20 -0200 |
commit | b224637928e9fc04e3cef3e10d02ccf042d01584 (patch) | |
tree | 5039ee55ad35414936bff34c31c5b3bd05a31e3a /ChangeLog | |
parent | e4d6a83565479c533aabae9046377a59712a5b22 (diff) | |
download | glibc-b224637928e9fc04e3cef3e10d02ccf042d01584.tar.gz glibc-b224637928e9fc04e3cef3e10d02ccf042d01584.tar.xz glibc-b224637928e9fc04e3cef3e10d02ccf042d01584.zip |
Fix powerpc64/power7 memchr for large input sizes
Current optimized powercp64/power7 memchr uses a strategy to check for p versus align(p+n) (where 'p' is the input char pointer and n the maximum size to check for the byte) without taking care for possible overflow on the pointer addition in case of large 'n'. It was triggered by 3038145ca23 where default rawmemchr (used to created ppc64 rawmemchr in ifunc selection) now uses memchr (p, c, (size_t)-1) on its implementation. This patch fixes it by implement a satured addition where overflows sets the maximum pointer size to UINTPTR_MAX. Checked on powerpc64le-linux-gnu. [BZ# 20971] * sysdeps/powerpc/powerpc64/power7/memchr.S (__memchr): Avoid overflow in pointer addition. * string/test-memchr.c (do_test): Add an argument to pass as the size on memchr. (test_main): Add check for SIZE_MAX.
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 374a69f8db..628540538b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2016-12-16 Adhemerval Zanella <adhemerval.zanella@linaro.org> + + [BZ# 20971] + * sysdeps/powerpc/powerpc64/power7/memchr.S (__memchr): Avoid + overflow in pointer addition. + * string/test-memchr.c (do_test): Add an argument to pass as + the size on memchr. + (test_main): Add check for SIZE_MAX. + 2016-12-16 Gabriel F. T. Gomes <gftg@linux.vnet.ibm.com> * math/Makefile (gen-libm-calls): Remove w_scalblnF. |