diff options
author | Joseph Myers <joseph@codesourcery.com> | 2018-07-18 21:04:12 +0000 |
---|---|---|
committer | Joseph Myers <joseph@codesourcery.com> | 2018-07-18 21:04:12 +0000 |
commit | 5c112f1b62b6fca7348c64a004e9fc4cfdaca1ad (patch) | |
tree | 67ea596cd3c6810bb13df1fb6a1e0d2ae29f7120 /ChangeLog | |
parent | 6d90776dff7e70e08fa46f9cd7576dd0eeb06da2 (diff) | |
download | glibc-5c112f1b62b6fca7348c64a004e9fc4cfdaca1ad.tar.gz glibc-5c112f1b62b6fca7348c64a004e9fc4cfdaca1ad.tar.xz glibc-5c112f1b62b6fca7348c64a004e9fc4cfdaca1ad.zip |
Avoid insecure usage of tmpnam in tests.
Various glibc testcases use tmpnam in ways subject to race conditions (generate a temporary file name, then later open that file without O_EXCL). This patch fixes those tests to use mkstemp - generally a minimal local fix to use mkstemp instead of tmpnam, rather than a larger fix to use other testsuite infrastructure for temporary files. The unchanged use of tmpnam in posix/wordexp-test.c would fail safe in the event of a race (it's generating a name for use with mkdir rather than for a file to be opened for writing). Tested for x86_64. * grp/tst_fgetgrent.c: Include <unistd.h>. (main): Use mkstemp instead of tmpnam. * io/test-utime.c (main): Likewise. * posix/annexc.c (macrofile): Change to modifiable array. (get_null_defines): Use mkstemp instead of tmpnam. Do not remove macrofile here. * posix/bug-getopt1.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt2.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt3.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt4.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * posix/bug-getopt5.c: Include <stdlib.h>. (do_test): Use mkstemp instead of tmpnam. * stdio-common/bug7.c: Include <stdlib.h> and <unistd.h>. (main): Use mkstemp instead of tmpnam. * stdio-common/tst-fdopen.c: Include <stdlib.h>. (main): Use mkstemp instead of tmpnam. * stdio-common/tst-ungetc.c: Include <stdlib.h>. (main): use mkstemp instead of tmpnam. * stdlib/isomac.c (macrofile): Change to modifiable array. (get_null_defines): Use mkstemp instead of tmpnam. Do not remove macrofile here.
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 32 |
1 files changed, 32 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index b489ce06ad..a678087880 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,35 @@ +2018-07-18 Joseph Myers <joseph@codesourcery.com> + + * grp/tst_fgetgrent.c: Include <unistd.h>. + (main): Use mkstemp instead of tmpnam. + * io/test-utime.c (main): Likewise. + * posix/annexc.c (macrofile): Change to modifiable array. + (main): Remove macrofile here. + (get_null_defines): Use mkstemp instead of tmpnam. Do not remove + macrofile here. + (check_header): Do not remove macrofile here. + * posix/bug-getopt1.c: Include <stdlib.h>. + (do_test): Use mkstemp instead of tmpnam. + * posix/bug-getopt2.c: Include <stdlib.h>. + (do_test): Use mkstemp instead of tmpnam. + * posix/bug-getopt3.c: Include <stdlib.h>. + (do_test): Use mkstemp instead of tmpnam. + * posix/bug-getopt4.c: Include <stdlib.h>. + (do_test): Use mkstemp instead of tmpnam. + * posix/bug-getopt5.c: Include <stdlib.h>. + (do_test): Use mkstemp instead of tmpnam. + * stdio-common/bug7.c: Include <stdlib.h> and <unistd.h>. + (main): Use mkstemp instead of tmpnam. + * stdio-common/tst-fdopen.c: Include <stdlib.h>. + (main): Use mkstemp instead of tmpnam. + * stdio-common/tst-ungetc.c: Include <stdlib.h>. + (main): use mkstemp instead of tmpnam. + * stdlib/isomac.c (macrofile): Change to modifiable array. + (main): Remove macrofile here. + (get_null_defines): Use mkstemp instead of tmpnam. Do not remove + macrofile here. + (check_header): Do not remove macrofile here. + 2018-07-18 H.J. Lu <hongjiu.lu@intel.com> * manual/tunables.texi: Document glibc.tune.x86_ibt and |