about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2017-07-24 06:06:08 -0700
committerH.J. Lu <hjl.tools@gmail.com>2017-07-24 06:06:24 -0700
commit422ff87c249ddc06701d096421db63343e4754be (patch)
treee095970d350bffebdd21f9fa75a24494aeebbc47 /ChangeLog
parent55703fcace89b53d7f41f7d85ede50571da2bcc8 (diff)
downloadglibc-422ff87c249ddc06701d096421db63343e4754be.tar.gz
glibc-422ff87c249ddc06701d096421db63343e4754be.tar.xz
glibc-422ff87c249ddc06701d096421db63343e4754be.zip
Avoid accessing corrupted stack from __stack_chk_fail [BZ #21752]
__libc_argv[0] points to address on stack and __libc_secure_getenv
accesses environment variables which are on stack.  We should avoid
accessing stack when stack is corrupted.

This patch also renames function argument in __fortify_fail_abort
from do_backtrace to need_backtrace to avoid confusion with do_backtrace
from enum __libc_message_action.

	[BZ #21752]
	* debug/fortify_fail.c (__fortify_fail_abort): Don't pass down
	__libc_argv[0] if we aren't doing backtrace.  Rename do_backtrace
	to need_backtrace.
	* sysdeps/posix/libc_fatal.c (__libc_message): Don't call
	__libc_secure_getenv if we aren't doing backtrace.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog9
1 files changed, 9 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 6f1fb54730..7da4510060 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2017-07-24  H.J. Lu  <hongjiu.lu@intel.com>
+
+	[BZ #21752]
+	* debug/fortify_fail.c (__fortify_fail_abort): Don't pass down
+	__libc_argv[0] if we aren't doing backtrace.  Rename do_backtrace
+	to need_backtrace.
+	* sysdeps/posix/libc_fatal.c (__libc_message): Don't call
+	__libc_secure_getenv if we aren't doing backtrace.
+
 2017-07-24  Andreas Schwab  <schwab@suse.de>
 
 	[BZ #21804]