about summary refs log tree commit diff
path: root/ChangeLog.1
diff options
context:
space:
mode:
authorLeonhard Holz <leonhard.holz@web.de>2015-01-13 11:33:56 +0530
committerSiddhesh Poyarekar <siddhesh@redhat.com>2015-01-13 11:33:56 +0530
commit0f9e585480edcdf1e30dc3d79e24b84aeee516fa (patch)
tree357b0633c0f6ed2e260db8155609fb3a60cfc963 /ChangeLog.1
parentc60ec0e016f9e2444c7bc2703fc6b671a26f0f5e (diff)
downloadglibc-0f9e585480edcdf1e30dc3d79e24b84aeee516fa.tar.gz
glibc-0f9e585480edcdf1e30dc3d79e24b84aeee516fa.tar.xz
glibc-0f9e585480edcdf1e30dc3d79e24b84aeee516fa.zip
Fix memory handling in strxfrm_l [BZ #16009]
[Modified from the original email by Siddhesh Poyarekar]

This patch solves bug #16009 by implementing an additional path in
strxfrm that does not depend on caching the weight and rule indices.

In detail the following changed:

* The old main loop was factored out of strxfrm_l into the function
do_xfrm_cached to be able to alternativly use the non-caching version
do_xfrm.

* strxfrm_l allocates a a fixed size array on the stack. If this is not
sufficiant to store the weight and rule indices, the non-caching path is
taken. As the cache size is not dependent on the input there can be no
problems with integer overflows or stack allocations greater than
__MAX_ALLOCA_CUTOFF. Note that malloc-ing is not possible because the
definition of strxfrm does not allow an oom errorhandling.

* The uncached path determines the weight and rule index for every char
and for every pass again.

* Passing all the locale data array by array resulted in very long
parameter lists, so I introduced a structure that holds them.

* Checking for zero src string has been moved a bit upwards, it is
before the locale data initialization now.

* To verify that the non-caching path works correct I added a test run
to localedata/sort-test.sh & localedata/xfrm-test.c where all strings
are patched up with spaces so that they are too large for the caching path.
Diffstat (limited to 'ChangeLog.1')
0 files changed, 0 insertions, 0 deletions