about summary refs log tree commit diff
diff options
context:
space:
mode:
authorStefan Liebler <stli@linux.ibm.com>2019-06-26 12:29:50 +0200
committerStefan Liebler <stli@linux.ibm.com>2019-06-26 12:29:50 +0200
commitc78b3f55d12c3599c5492b1883a48e5e3c391ccf (patch)
tree422f3446f0af701008452caca1bd9ae8a33bbba2
parent9e6a7d9c179650478c8c34b8cf81a7699dc2ffe3 (diff)
downloadglibc-c78b3f55d12c3599c5492b1883a48e5e3c391ccf.tar.gz
glibc-c78b3f55d12c3599c5492b1883a48e5e3c391ccf.tar.xz
glibc-c78b3f55d12c3599c5492b1883a48e5e3c391ccf.zip
Fix build warnings in nptl/tst-eintr1.c
This patch fixes the gcc warnings seen with gcc 9.1 -O3 on s390x:
tst-eintr1.c: In function ‘tf1’:
tst-eintr1.c:46:1: error: no return statement in function returning non-void [-Werror=return-type]
   46 | }
      | ^
tst-eintr1.c: In function ‘do_test’:
tst-eintr1.c:57:17: error: unused variable ‘th’ [-Werror=unused-variable]
   57 |       pthread_t th = xpthread_create (NULL, tf1, NULL);
      |                 ^~

ChangeLog:

	* nptl/tst-eintr1.c (tf1): Add return statement.
	(do_test): Remove unused th variable.
-rw-r--r--ChangeLog5
-rw-r--r--nptl/tst-eintr1.c5
2 files changed, 7 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index adc58e4a14..2e54659370 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2019-06-26  Stefan Liebler  <stli@linux.ibm.com>
 
+	* nptl/tst-eintr1.c (tf1): Add return statement.
+	(do_test): Remove unused th variable.
+
+2019-06-26  Stefan Liebler  <stli@linux.ibm.com>
+
 	* locale/programs/ld-ctype.c (charclass_symbolic_ellipsis):
 	Return error if get_character fails.
 
diff --git a/nptl/tst-eintr1.c b/nptl/tst-eintr1.c
index b60b796d61..11404ff7ff 100644
--- a/nptl/tst-eintr1.c
+++ b/nptl/tst-eintr1.c
@@ -43,6 +43,7 @@ tf1 (void *arg)
       pthread_t th = xpthread_create (NULL, tf2, NULL);
       xpthread_join (th);
     }
+  return NULL;
 }
 
 
@@ -53,9 +54,7 @@ do_test (void)
 
   int i;
   for (i = 0; i < 10; ++i)
-    {
-      pthread_t th = xpthread_create (NULL, tf1, NULL);
-    }
+    xpthread_create (NULL, tf1, NULL);
 
   delayed_exit (3);
   /* This call must never return.  */