about summary refs log tree commit diff
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2017-07-29 21:04:09 -0700
committerH.J. Lu <hjl.tools@gmail.com>2017-08-21 05:34:54 -0700
commit7b3ce39538c890442a2e46b57bf1911ef7ab8ff8 (patch)
treeaf197720cf4a3f54f0f863de3ac348dd8de10414
parent54e4b8f21590d57ec9a2f2ad81a17c57e3b3984f (diff)
downloadglibc-7b3ce39538c890442a2e46b57bf1911ef7ab8ff8.tar.gz
glibc-7b3ce39538c890442a2e46b57bf1911ef7ab8ff8.tar.xz
glibc-7b3ce39538c890442a2e46b57bf1911ef7ab8ff8.zip
Don't compile non-lib modules as lib modules [BZ #21864]
Some programs have more than one source files.  These non-lib modules
should not be compiled with -DMODULE_NAME=libc.  This patch puts these
non-lib modules in $(others-extras) and adds $(others-extras) to
all-nonlib.

	[BZ #21864]
	* Makerules (all-nonlib): Add $(others-extras).
	* catgets/Makefile (others-extras): New.
	* elf/Makefile (others-extras): Likewise.
	* nss/Makefile (others-extras): Likewise.
-rw-r--r--Makerules3
-rw-r--r--catgets/Makefile1
-rw-r--r--elf/Makefile1
-rw-r--r--nss/Makefile1
4 files changed, 5 insertions, 1 deletions
diff --git a/Makerules b/Makerules
index 9bb707c168..8f1324d8e9 100644
--- a/Makerules
+++ b/Makerules
@@ -1359,7 +1359,8 @@ lib := testsuite
 include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
 endif
 
-all-nonlib := $(strip $(tests-internal) $(test-internal-extras) $(others))
+all-nonlib := $(strip $(tests-internal) $(test-internal-extras) \
+		      $(others) $(others-extras))
 ifneq (,$(all-nonlib))
 cpp-srcs-left = $(all-nonlib)
 lib := nonlib
diff --git a/catgets/Makefile b/catgets/Makefile
index e5f49491fb..39aab67c14 100644
--- a/catgets/Makefile
+++ b/catgets/Makefile
@@ -38,6 +38,7 @@ tests-special += $(objpfx)tst-catgets-mem.out
 endif
 
 gencat-modules	= xmalloc
+others-extras   = $(gencat-modules)
 
 # To find xmalloc.c
 vpath %.c ../locale/programs
diff --git a/elf/Makefile b/elf/Makefile
index d314a5fa7e..7cf959aabd 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -112,6 +112,7 @@ install-rootsbin += ldconfig
 
 ldconfig-modules := cache readlib xmalloc xstrdup chroot_canon static-stubs
 extra-objs	+= $(ldconfig-modules:=.o)
+others-extras   = $(ldconfig-modules)
 endif
 endif
 
diff --git a/nss/Makefile b/nss/Makefile
index 1e298c28f1..0369249f30 100644
--- a/nss/Makefile
+++ b/nss/Makefile
@@ -47,6 +47,7 @@ CPPFLAGS-getent.c	= -DHAVE_SUNRPC=$(have-sunrpc)
 others                  := getent makedb
 install-bin             := getent makedb
 makedb-modules = xmalloc hash-string
+others-extras		= $(makedb-modules)
 extra-objs		+= $(makedb-modules:=.o)
 
 tests-static            = tst-field