diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2017-03-20 04:47:56 -0400 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2017-03-20 10:42:34 -0400 |
| commit | ddc3fb333469c2997798742dc0509dc1e3201d91 (patch) | |
| tree | 5fb5f8ede997d6e039eb867867caf971afd52dae | |
| parent | 15e9a4f378c8607c2ae1aa465436af4321db0e23 (diff) | |
| download | glibc-ddc3fb333469c2997798742dc0509dc1e3201d91.tar.gz glibc-ddc3fb333469c2997798742dc0509dc1e3201d91.tar.xz glibc-ddc3fb333469c2997798742dc0509dc1e3201d91.zip | |
posix_spawn: fix stack setup on ia64 [BZ #21275]
The ia64-specific clone2 call expects the base of the stack mapping and the stack size as sep arguments, not an initial stack value as on other stack-grows-down architectures. Reuse the stack-grows-up macro so we pass in the right stack base. Reported-by: Matt Turner <mattst88@gentoo.org>
| -rw-r--r-- | ChangeLog | 8 | ||||
| -rw-r--r-- | sysdeps/unix/sysv/linux/spawni.c | 11 |
2 files changed, 14 insertions, 5 deletions
diff --git a/ChangeLog b/ChangeLog index e732c7d46b..578714c4fb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2017-03-20 Mike Frysinger <vapier@gentoo.org> + + [BZ #21275] + * sysdeps/unix/sysv/linux/spawni.c [__ia64__] (CLONE): Rename + __stack to __stackbase. + (STACK): Invert _STACK_GROWS_DOWN and _STACK_GROWS_UP order of + checks so we can include defined(__ia64__) first. + 2017-03-19 Christian Brauner <christian.brauner@ubuntu.com> * sysdeps/unix/sysv/linux/ttyname.h: New file. diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c index 24f75dbd9c..b82a5e8f3c 100644 --- a/sysdeps/unix/sysv/linux/spawni.c +++ b/sysdeps/unix/sysv/linux/spawni.c @@ -61,17 +61,18 @@ #define SPAWN_ERROR 127 #ifdef __ia64__ -# define CLONE(__fn, __stack, __stacksize, __flags, __args) \ - __clone2 (__fn, __stack, __stacksize, __flags, __args, 0, 0, 0) +# define CLONE(__fn, __stackbase, __stacksize, __flags, __args) \ + __clone2 (__fn, __stackbase, __stacksize, __flags, __args, 0, 0, 0) #else # define CLONE(__fn, __stack, __stacksize, __flags, __args) \ __clone (__fn, __stack, __flags, __args) #endif -#if _STACK_GROWS_DOWN -# define STACK(__stack, __stack_size) (__stack + __stack_size) -#elif _STACK_GROWS_UP +/* Since ia64 wants the stackbase w/clone2, re-use the grows-up macro. */ +#if _STACK_GROWS_UP || defined (__ia64__) # define STACK(__stack, __stack_size) (__stack) +#elif _STACK_GROWS_DOWN +# define STACK(__stack, __stack_size) (__stack + __stack_size) #endif |