about summary refs log tree commit diff
diff options
context:
space:
mode:
authorNoah Goldstein <goldstein.w.n@gmail.com>2023-08-11 18:48:18 -0500
committerNoah Goldstein <goldstein.w.n@gmail.com>2023-09-11 22:48:44 -0500
commit402324a71073ac36d334845a71a5f97350aebbc3 (patch)
treec38e649eb6db5305599e2a00761bc13688fdeb0d
parentba37e6a4d17ad7a3871542953d9ebaf60034a76e (diff)
downloadglibc-402324a71073ac36d334845a71a5f97350aebbc3.tar.gz
glibc-402324a71073ac36d334845a71a5f97350aebbc3.tar.xz
glibc-402324a71073ac36d334845a71a5f97350aebbc3.zip
x86: Fix slight bug in `shared_per_thread` cache size calculation.
After:
```
    commit af992e7abdc9049714da76cae1e5e18bc4838fb8
    Author: Noah Goldstein <goldstein.w.n@gmail.com>
    Date:   Wed Jun 7 13:18:01 2023 -0500

        x86: Increase `non_temporal_threshold` to roughly `sizeof_L3 / 4`
```

Split `shared` (cumulative cache size) from `shared_per_thread` (cache
size per socket), the `shared_per_thread` *can* be slightly off from
the previous calculation.

Previously we added `core` even if `threads_l2` was invalid, and only
used `threads_l2` to divide `core` if it was present. The changed
version only included `core` if `threads_l2` was valid.

This change restores the old behavior if `threads_l2` is invalid by
adding the entire value of `core`.
Reviewed-by: DJ Delorie <dj@redhat.com>

(cherry picked from commit 47f747217811db35854ea06741be3685e8bbd44d)
-rw-r--r--sysdeps/x86/cacheinfo.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
index 4354c01c71..6baec4d7ed 100644
--- a/sysdeps/x86/cacheinfo.c
+++ b/sysdeps/x86/cacheinfo.c
@@ -696,8 +696,8 @@ init_cacheinfo (void)
       /* Account for non-inclusive L2 and L3 caches.  */
       if (!inclusive_cache)
 	{
-      if (threads_l2 > 0)
-	shared_per_thread += core / threads_l2;
+      long int core_per_thread = threads_l2 > 0 ? (core / threads_l2) : core;
+      shared_per_thread += core_per_thread;
 	  shared += core;
 	}
     }