about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2017-01-12 01:52:37 +0000
committerJoseph Myers <joseph@codesourcery.com>2017-01-12 01:52:37 +0000
commit4dfb9c941132d7b10b897c678f360fd27d6f5c95 (patch)
treed23f1574d0c125532196465cbe291679c20e976b
parent6a1cefac196f45d766027c97a6c8c44459c9cccd (diff)
downloadglibc-4dfb9c941132d7b10b897c678f360fd27d6f5c95.tar.gz
glibc-4dfb9c941132d7b10b897c678f360fd27d6f5c95.tar.xz
glibc-4dfb9c941132d7b10b897c678f360fd27d6f5c95.zip
Make fallback fegetexceptflag work with generic fetestexceptflag.
The generic implementation of fetestexceptflag does:

int
fetestexceptflag (const fexcept_t *flagp, int excepts)
{
  /* Most versions of fegetexceptflag store exceptions in a form such
     that this works.  */
  return *flagp & excepts & FE_ALL_EXCEPT;
}

In the case where FE_ALL_EXCEPT is nonzero but exceptions may not be
supported at runtime, this only works if fegetexceptflag cleared all
the bits of FE_ALL_EXCEPT in *flagp; otherwise it accesses
uninitialized data.  This showed up as a failure of
math/test-fetestexceptflag for MIPS o32 soft-float.  This patch makes
the fallback fegetexceptflag store 0 (fexcept_t is an integer type
everywhere) so that this works.  (No bug report in Bugzilla because
this wasn't user-visible - at least, without using tools to detect
uninitialized memory use at runtime - without fetestexceptflag, which
is new in 2.25.)

Tested for MIPS o32 soft-float.

	* math/fgetexcptflg.c (__fegetexceptflag): Store 0 in fexcept_t
	object.
-rw-r--r--ChangeLog5
-rw-r--r--math/fgetexcptflg.c1
2 files changed, 6 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index d86a9c76f4..5b0601fa1b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2017-01-12  Joseph Myers  <joseph@codesourcery.com>
+
+	* math/fgetexcptflg.c (__fegetexceptflag): Store 0 in fexcept_t
+	object.
+
 2017-01-11  Joseph Myers  <joseph@codesourcery.com>
 
 	[BZ #16458]
diff --git a/math/fgetexcptflg.c b/math/fgetexcptflg.c
index 8e16250e3b..95a9217198 100644
--- a/math/fgetexcptflg.c
+++ b/math/fgetexcptflg.c
@@ -24,6 +24,7 @@ int
 __fegetexceptflag (fexcept_t *flagp, int excepts)
 {
   /* Nothing to do.  */
+  *flagp = 0;
   return 0;
 }
 #if SHLIB_COMPAT (libm, GLIBC_2_1, GLIBC_2_2)