diff options
| author | Florian Weimer <fweimer@redhat.com> | 2024-05-02 17:06:19 +0200 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2024-05-02 19:05:10 +0200 |
| commit | 90304900c358e5302f870150787078f0b359d05e (patch) | |
| tree | d2b86909cf3df8d66ed5fdcc4b8acd79b38be643 | |
| parent | 36ef0d2f2f89963809996590369b3c9581d81274 (diff) | |
| download | glibc-90304900c358e5302f870150787078f0b359d05e.tar.gz glibc-90304900c358e5302f870150787078f0b359d05e.tar.xz glibc-90304900c358e5302f870150787078f0b359d05e.zip | |
nscd: Use time_t for return type of addgetnetgrentX
Using int may give false results for future dates (timeouts after the
year 2028).
Fixes commit 04a21e050d64a1193a6daab872bca2528bda44b ("CVE-2024-33601,
CVE-2024-33602: nscd: netgroup: Use two buffers in addgetnetgrentX
(bug 31680)").
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
(cherry picked from commit 4bbca1a44691a6e9adcee5c6798a707b626bc331)
| -rw-r--r-- | nscd/netgroupcache.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c index 72d7a52cb4..21d5bde12f 100644 --- a/nscd/netgroupcache.c +++ b/nscd/netgroupcache.c @@ -680,8 +680,8 @@ readdinnetgr (struct database_dyn *db, struct hashentry *he, .key_len = he->len }; - int timeout = addinnetgrX (db, -1, &req, db->data + he->key, he->owner, - he, dh); + time_t timeout = addinnetgrX (db, -1, &req, db->data + he->key, he->owner, + he, dh); if (timeout < 0) timeout = 0; return timeout; |