about summary refs log tree commit diff
diff options
context:
space:
mode:
authorSiddhesh Poyarekar <siddhesh@redhat.com>2014-07-09 10:36:50 +0530
committerSiddhesh Poyarekar <siddhesh@redhat.com>2014-07-09 10:36:50 +0530
commit6ee3eab42979fdd5bb971a40fec32e04bb9dd2ad (patch)
tree70452bbbb53f12492f2685494adca1b079637525
parent6680738a18fc219de2e4f7be1d53e4fb251f1166 (diff)
downloadglibc-6ee3eab42979fdd5bb971a40fec32e04bb9dd2ad.tar.gz
glibc-6ee3eab42979fdd5bb971a40fec32e04bb9dd2ad.tar.xz
glibc-6ee3eab42979fdd5bb971a40fec32e04bb9dd2ad.zip
Fix -Wmaybe-uninitialized warning in xdr.c
While we're at fixing build warnings, here's one unnecessary warning
that can be fixed fairly easily.  The SIZE variable is never actually
use uninitialized, but the compiler cannot make that out and thinks
(correctly) that there is a potential for accessing SIZE without
initializing it.  Make this safe by initializing SIZE to 0.

Tested on x86_64.
-rw-r--r--ChangeLog2
-rw-r--r--sunrpc/xdr.c2
2 files changed, 3 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index b70d3370a5..0773d7ce18 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 2014-07-09  Siddhesh Poyarekar  <siddhesh@redhat.com>
 
+	* sunrpc/xdr.c (xdr_string): Initialize SIZE to 0.
+
 	* sysdeps/generic/unwind-pe.h: Only check if __cplusplus is
 	defined.
 
diff --git a/sunrpc/xdr.c b/sunrpc/xdr.c
index b3f96ca4dc..129abd8f00 100644
--- a/sunrpc/xdr.c
+++ b/sunrpc/xdr.c
@@ -739,7 +739,7 @@ xdr_string (xdrs, cpp, maxsize)
      u_int maxsize;
 {
   char *sp = *cpp;	/* sp is the actual string pointer */
-  u_int size;
+  u_int size = 0;
   u_int nodesize;
 
   /*