about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2019-05-27 12:57:45 +0200
committerFlorian Weimer <fweimer@redhat.com>2019-05-27 12:57:45 +0200
commit85188d8211698d1a255f0aec6529546db5c56de3 (patch)
tree22642bf4a1b9068291ebb49ec9204a1f9ac2d15c
parent5c23c82195fc9e95ae34180250f64438f1e6fb0b (diff)
downloadglibc-85188d8211698d1a255f0aec6529546db5c56de3.tar.gz
glibc-85188d8211698d1a255f0aec6529546db5c56de3.tar.xz
glibc-85188d8211698d1a255f0aec6529546db5c56de3.zip
nptl: Add comment to __pthread_get_minstack about external users
-rw-r--r--ChangeLog4
-rw-r--r--nptl/nptl-init.c8
2 files changed, 12 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index b46b581707..53a3ae4ddb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2019-05-27  Florian Weimer  <fweimer@redhat.com>
+
+	* nptl/nptl-init.c: Add comment.
+
 2019-05-24  Florian Weimer  <fweimer@redhat.com>
 
 	* resolv/nss_dns/dns-host.c (getanswer_r): Be more explicit about
diff --git a/nptl/nptl-init.c b/nptl/nptl-init.c
index 2926558b91..73935f8be4 100644
--- a/nptl/nptl-init.c
+++ b/nptl/nptl-init.c
@@ -407,6 +407,14 @@ strong_alias (__pthread_initialize_minimal_internal,
 	      __pthread_initialize_minimal)
 
 
+/* This function is internal (it has a GLIBC_PRIVATE) version, but it
+   is widely used (either via weak symbol, or dlsym) to obtain the
+   __static_tls_size value.  This value is then used to adjust the
+   value of the stack size attribute, so that applications receive the
+   full requested stack size, not diminished by the TCB and static TLS
+   allocation on the stack.  Once the TCB is separately allocated,
+   this function should be removed or renamed (if it is still
+   necessary at that point).  */
 size_t
 __pthread_get_minstack (const pthread_attr_t *attr)
 {