about summary refs log tree commit diff
diff options
context:
space:
mode:
authorRoland McGrath <roland@hack.frob.com>2014-12-11 13:52:57 -0800
committerRoland McGrath <roland@hack.frob.com>2014-12-11 13:52:57 -0800
commit73b0c1a19c679745897b9fa2efef0c00469efa92 (patch)
treea07af1e284cbc6dd91c6f424eab282685c2a3c03
parent1c4053db63e2a3470ed8ace2ddd9636f9a6e135c (diff)
downloadglibc-73b0c1a19c679745897b9fa2efef0c00469efa92.tar.gz
glibc-73b0c1a19c679745897b9fa2efef0c00469efa92.tar.xz
glibc-73b0c1a19c679745897b9fa2efef0c00469efa92.zip
Suppress -Wformat-security in tst-error1.c.
-rw-r--r--ChangeLog3
-rw-r--r--misc/tst-error1.c11
2 files changed, 14 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index ad8fe210aa..35d61bd3cb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2014-12-11  Roland McGrath  <roland@hack.frob.com>
 
+	* misc/tst-error1.c (do_test): Ignore -Wformat-security for
+	generated error format strings.
+
 	* stdio-common/tstdiomisc.c (t2): Ignore -Wformat and
 	-Wformat-extra-args warnings for scanf formats.
 	* stdio-common/scanf4.c (main): Ignore -Wformat-zero-length around
diff --git a/misc/tst-error1.c b/misc/tst-error1.c
index e84843ed2f..a97a22ce9d 100644
--- a/misc/tst-error1.c
+++ b/misc/tst-error1.c
@@ -3,6 +3,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <wchar.h>
+#include <libc-internal.h>
 
 static int
 do_test (int argc, char *argv[])
@@ -16,8 +17,18 @@ do_test (int argc, char *argv[])
   for (int i = 0; i < 1000; ++i)
     memcpy (&buf[i * (sizeof (str) - 1)], str, sizeof (str));
   error (0, 0, str);
+
+  /* We're testing a large format string here and need to generate it
+     to avoid this source file being ridiculous.  So disable the warning
+     about a generated format string.  */
+  DIAG_PUSH_NEEDS_COMMENT;
+  DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wformat-security");
+
   error (0, 0, buf);
   error (0, 0, buf);
+
+  DIAG_POP_NEEDS_COMMENT;
+
   error (0, 0, str);
   return 0;
 }