about summary refs log tree commit diff
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2015-10-15 13:41:21 -0700
committerH.J. Lu <hjl.tools@gmail.com>2015-10-15 13:48:54 -0700
commit9edf9b18b1dc5de0f3d76c42877b405cb439df4f (patch)
tree1873051179c1a2f0f3e8c109174f4c3e929ccbdc
parent983a33fa7d50aa8bcff1e0f183388c74b1b5e213 (diff)
downloadglibc-9edf9b18b1dc5de0f3d76c42877b405cb439df4f.tar.gz
glibc-9edf9b18b1dc5de0f3d76c42877b405cb439df4f.tar.xz
glibc-9edf9b18b1dc5de0f3d76c42877b405cb439df4f.zip
Mark x86 _dl_unmap/_dl_make_tlsdesc_dynamic hidden
Since x86 _dl_unmap and _dl_make_tlsdesc_dynamic are only used
internally in ld.so, they can be made hidden.

	[BZ #19122]
	* sysdeps/i386/dl-lookupcfg.h (_dl_unmap): Add attribute_hidden.
	* sysdeps/i386/dl-tlsdesc.h (_dl_make_tlsdesc_dynamic):
	Likewise.
	* sysdeps/x86_64/dl-tlsdesc.h (_dl_make_tlsdesc_dynamic):
	Likewise.
	* sysdeps/x86_64/dl-lookupcfg.h (_dl_unmap): Likewise.
-rw-r--r--ChangeLog10
-rw-r--r--sysdeps/i386/dl-lookupcfg.h3
-rw-r--r--sysdeps/i386/dl-tlsdesc.h5
-rw-r--r--sysdeps/x86_64/dl-lookupcfg.h3
-rw-r--r--sysdeps/x86_64/dl-tlsdesc.h5
5 files changed, 20 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog
index 6f103e8632..0edfbe5956 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
 2015-10-15  H.J. Lu  <hongjiu.lu@intel.com>
 
+	[BZ #19122]
+	* sysdeps/i386/dl-lookupcfg.h (_dl_unmap): Add attribute_hidden.
+	* sysdeps/i386/dl-tlsdesc.h (_dl_make_tlsdesc_dynamic):
+	Likewise.
+	* sysdeps/x86_64/dl-tlsdesc.h (_dl_make_tlsdesc_dynamic):
+	Likewise.
+	* sysdeps/x86_64/dl-lookupcfg.h (_dl_unmap): Likewise.
+
+2015-10-15  H.J. Lu  <hongjiu.lu@intel.com>
+
 	* sysdeps/unix/sysv/linux/i386/sysdep.h: Add comments for
 	GCC 5 requirement.
 
diff --git a/sysdeps/i386/dl-lookupcfg.h b/sysdeps/i386/dl-lookupcfg.h
index 310f261fec..a42d5ef482 100644
--- a/sysdeps/i386/dl-lookupcfg.h
+++ b/sysdeps/i386/dl-lookupcfg.h
@@ -26,6 +26,7 @@
 
 struct link_map;
 
-extern void internal_function _dl_unmap (struct link_map *map);
+extern void _dl_unmap (struct link_map *map)
+  internal_function attribute_hidden;
 
 #define DL_UNMAP(map) _dl_unmap (map)
diff --git a/sysdeps/i386/dl-tlsdesc.h b/sysdeps/i386/dl-tlsdesc.h
index c58423389e..ee6d7fa10a 100644
--- a/sysdeps/i386/dl-tlsdesc.h
+++ b/sysdeps/i386/dl-tlsdesc.h
@@ -50,8 +50,9 @@ extern ptrdiff_t attribute_hidden __attribute__ ((regparm (1)))
   _dl_tlsdesc_resolve_hold (struct tlsdesc *);
 
 # ifdef SHARED
-extern void *internal_function _dl_make_tlsdesc_dynamic (struct link_map *map,
-							 size_t ti_offset);
+extern void *_dl_make_tlsdesc_dynamic (struct link_map *map,
+				       size_t ti_offset)
+  internal_function attribute_hidden;
 
 extern ptrdiff_t attribute_hidden __attribute__ ((regparm (1)))
   _dl_tlsdesc_dynamic (struct tlsdesc *);
diff --git a/sysdeps/x86_64/dl-lookupcfg.h b/sysdeps/x86_64/dl-lookupcfg.h
index 310f261fec..a42d5ef482 100644
--- a/sysdeps/x86_64/dl-lookupcfg.h
+++ b/sysdeps/x86_64/dl-lookupcfg.h
@@ -26,6 +26,7 @@
 
 struct link_map;
 
-extern void internal_function _dl_unmap (struct link_map *map);
+extern void _dl_unmap (struct link_map *map)
+  internal_function attribute_hidden;
 
 #define DL_UNMAP(map) _dl_unmap (map)
diff --git a/sysdeps/x86_64/dl-tlsdesc.h b/sysdeps/x86_64/dl-tlsdesc.h
index cf32328264..542641d4b8 100644
--- a/sysdeps/x86_64/dl-tlsdesc.h
+++ b/sysdeps/x86_64/dl-tlsdesc.h
@@ -60,8 +60,9 @@ extern ptrdiff_t attribute_hidden
   _dl_tlsdesc_resolve_hold(struct tlsdesc *on_rax);
 
 # ifdef SHARED
-extern void *internal_function _dl_make_tlsdesc_dynamic (struct link_map *map,
-							 size_t ti_offset);
+extern void *_dl_make_tlsdesc_dynamic (struct link_map *map,
+				       size_t ti_offset)
+  internal_function attribute_hidden;
 
 extern ptrdiff_t attribute_hidden _dl_tlsdesc_dynamic(struct tlsdesc *);
 # endif