diff options
| author | Ulrich Drepper <drepper@redhat.com> | 2010-11-22 11:11:24 -0500 |
|---|---|---|
| committer | Ulrich Drepper <drepper@redhat.com> | 2010-11-22 11:11:24 -0500 |
| commit | 3056dcdb783a177158a5617657d1a33f872358d6 (patch) | |
| tree | 5ecaf81b3305f617e74d6241b2c86a5b87cf96b5 | |
| parent | cf7c9078a5acdbb435498ace92cd81009637a971 (diff) | |
| download | glibc-3056dcdb783a177158a5617657d1a33f872358d6.tar.gz glibc-3056dcdb783a177158a5617657d1a33f872358d6.tar.xz glibc-3056dcdb783a177158a5617657d1a33f872358d6.zip | |
Fix multiple nss_compat initgroups() bugs
Compat initgroups() is completely broken; the code will always set skip_initgroups_dyn to true, so initgroups() will never be actually called, but due to the nature of the code, setgrent() won't be called either - thus, subsequent invocations of initgroups() will not return the NIS group list anymore. This is a simple patch that makes sure skip_initgroups_dyn is set only in case initgroups is not available; it also attempts to handle the unavailability of other NSS interfaces better. Conflicts: ChangeLog
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | nis/nss_compat/compat-initgroups.c | 19 |
2 files changed, 17 insertions, 8 deletions
diff --git a/ChangeLog b/ChangeLog index 124dd4c9d7..66bc545f00 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2010-05-31 Petr Baudis <pasky@suse.cz> + + [BZ #10085] + * nis/nss_compat/compat-initgroups.c (internal_getgrent_r): Fix + initialization of skip_initgroups_dyn. + 2010-11-19 Ulrich Drepper <drepper@gmail.com> * sysdeps/unix/sysv/linux/i386/bits/mman.h: Define MAP_HUGETLB. diff --git a/nis/nss_compat/compat-initgroups.c b/nis/nss_compat/compat-initgroups.c index 07a3b9282c..de8d95c7d1 100644 --- a/nis/nss_compat/compat-initgroups.c +++ b/nis/nss_compat/compat-initgroups.c @@ -474,18 +474,21 @@ internal_getgrent_r (ent_t *ent, char *buffer, size_t buflen, const char *user, /* If the selected module does not support getgrent_r or initgroups_dyn, abort. We cannot find the needed group entries. */ - if (nss_getgrent_r == NULL && nss_initgroups_dyn == NULL) + if (nss_initgroups_dyn == NULL || nss_getgrgid_r == NULL) + { + if (nss_setgrent != NULL) + { + nss_setgrent (1); + ent->need_endgrent = true; + } + ent->skip_initgroups_dyn = true; + } + + if (ent->skip_initgroups_dyn && nss_getgrent_r == NULL) return NSS_STATUS_UNAVAIL; ent->files = false; - if (nss_initgroups_dyn == NULL && nss_setgrent != NULL) - { - nss_setgrent (1); - ent->need_endgrent = true; - } - ent->skip_initgroups_dyn = true; - return getgrent_next_nss (ent, buffer, buflen, user, group, start, size, groupsp, limit, errnop); } |