diff options
| author | Pranav Kant <prka@google.com> | 2023-12-28 22:46:30 +0000 |
|---|---|---|
| committer | Pranav Kant <prka@google.com> | 2023-12-28 22:46:32 +0000 |
| commit | 5ac69deee6f89df25fffc3db356e4acedc8ec09f (patch) | |
| tree | 675287ba84e39082f663bb7a6f52f4105b3787b3 | |
| parent | 57afddcb68c168e7cbe448d55c73a7842e21c52d (diff) | |
| download | glibc-5ac69deee6f89df25fffc3db356e4acedc8ec09f.tar.gz glibc-5ac69deee6f89df25fffc3db356e4acedc8ec09f.tar.xz glibc-5ac69deee6f89df25fffc3db356e4acedc8ec09f.zip | |
Get rid of WANT_FLOAT128 usage in floatn.h
This header is installed system-wide. It's not correct to introduce a new macro WANT_FLOAT128 in this because then we are either forcing the compiler to make it an inbuilt macro to make glibc expose all float128 functionality, or asking our clients to -DWANT_FLOAT128 to get float128 functionality in glibc. Given we are primarily going to have float128 enabled GRTE now, we don't need to have guards for non-float128 cases.
| -rw-r--r-- | Makefile | 4 | ||||
| -rw-r--r-- | math/Makefile | 4 | ||||
| -rw-r--r-- | sysdeps/x86/bits/floatn.h | 2 |
3 files changed, 1 insertions, 9 deletions
diff --git a/Makefile b/Makefile index 084fec3331..bea4e27f8d 100644 --- a/Makefile +++ b/Makefile @@ -252,10 +252,6 @@ mostlyclean: parent-mostlyclean tests-clean: @$(MAKE) subdir_testclean no_deps=t -ifeq ($(enable-float128),yes) -CPPFLAGS += -DWANT_FLOAT128=1 -endif - ifneq (,$(CXX)) vpath c++-types.data $(+sysdep_dirs) diff --git a/math/Makefile b/math/Makefile index 6ad3ccea20..ec7d91ca3d 100644 --- a/math/Makefile +++ b/math/Makefile @@ -160,10 +160,6 @@ gen-calls = s_ldexpF generated += $(foreach s,.c .S,$(call type-foreach, $(calls:s_%=m_%$(s)))) routines = $(call type-foreach, $(calls)) -ifeq ($(enable-float128),yes) -math-CPPFLAGS += -DWANT_FLOAT128=1 -endif - ifeq ($(build-mathvec),yes) # We need to install libm.so and libm.a as linker scripts # for transparent use of vector math library. diff --git a/sysdeps/x86/bits/floatn.h b/sysdeps/x86/bits/floatn.h index 9dd9d8a40d..7387bbae38 100644 --- a/sysdeps/x86/bits/floatn.h +++ b/sysdeps/x86/bits/floatn.h @@ -33,7 +33,7 @@ #if (defined __x86_64__ \ ? __GNUC_PREREQ (4, 3) \ : (defined __GNU__ ? __GNUC_PREREQ (4, 5) : __GNUC_PREREQ (4, 4))) \ - || (defined __clang__ && defined WANT_FLOAT128 && WANT_FLOAT128 == 1) + || defined __clang__ # define __HAVE_FLOAT128 1 #else # define __HAVE_FLOAT128 0 |